Skip to content
This repository was archived by the owner on Mar 16, 2025. It is now read-only.

NEW REPO HERE! - #178

Open
ThexXTURBOXx wants to merge 73 commits into
teranetsrl:masterfrom
ThexXTURBOXx:master
Open

NEW REPO HERE!#178
ThexXTURBOXx wants to merge 73 commits into
teranetsrl:masterfrom
ThexXTURBOXx:master

Conversation

@ThexXTURBOXx

@ThexXTURBOXx ThexXTURBOXx commented Oct 9, 2023

Copy link
Copy Markdown
Contributor

My fork is now the official version of oauth2_client

You can migrate by just upgrading your oauth2_client version inside your pubspec to at least ^4.0.0:

dependencies:
  oauth2_client: ^4.0.0

New source code: https://github.com/ThexXTURBOXx/oauth2_client

Fixes #172
Closes #173
Closes #176
Closes #177
Fixes #190
Closes #193
Closes #197
Fixes #203
Fixes #205

@codecov-commenter

codecov-commenter commented Oct 9, 2023

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.55%. Comparing base (80258cb) to head (04e9b60).

Files with missing lines Patch % Lines
lib/oauth2_client.dart 93.33% 1 Missing ⚠️
lib/oauth2_helper.dart 90.00% 1 Missing ⚠️
lib/src/io_web_auth.dart 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   88.14%   88.55%   +0.40%     
==========================================
  Files          11       11              
  Lines         447      463      +16     
==========================================
+ Hits          394      410      +16     
  Misses         53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ThexXTURBOXx

Copy link
Copy Markdown
Contributor Author

I have also bumped the SDK constraints and fixed more typos now :)

@natebgurutech

Copy link
Copy Markdown

I ran into an issue getting this package to work on Windows, I found after attaching the debugger in Visual Studio to the running process that a .cpp file in flutter_secure_storage was aborting and crashing the app.

I overrode the dependency in pubspec.yaml to the latest version of flutter_secure_storage like so:

dependency_overrides:
  flutter_secure_storage: 9.0.0

and it fixed the issue.

I see that this pull request also has this fix. Is it possible to get it pulled into the main repo?

@ThexXTURBOXx

ThexXTURBOXx commented Oct 27, 2023

Copy link
Copy Markdown
Contributor Author

@natebgurutech If you want to use my fork, you can also use it directly like this until this PR is merged and properly published:

dependency_overrides:
  oauth2_client:
    git:
      url: https://github.com/ThexXTURBOXx/oauth2_client.git

Comment thread pubspec.yaml Outdated
Comment thread lib/src/io_web_auth.dart Outdated
@btrautmann

Copy link
Copy Markdown

@okrad any chance we can get this merged?

@btrautmann

Copy link
Copy Markdown

My comment above can be ignored 😅 I ended up writing my own client in combination with UrlLauncher that achieves the same but has way more graceful handling of errors, etc. than oauth2_client. Appreciate this PR though as I've used it for the past 6 months or so!

@ThexXTURBOXx

Copy link
Copy Markdown
Contributor Author

This now also features a send function to use StreamedResponses in conjunction with this package.
Will this be merged at some point? This would be a crucial feature (along with the package updates) for many users, probably.

@ThexXTURBOXx

ThexXTURBOXx commented Jan 9, 2025

Copy link
Copy Markdown
Contributor Author

@teranetsrl @okrad Any updates here? :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

5 participants