Skip to content

fix(bundler): resolve preact import in SSR bundles #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeeCheneler merged 2 commits into from
Dec 18, 2025
Merged

fix(bundler): resolve preact import in SSR bundles #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f8f9f3
perf(dev): use SSR bundling instead of subprocess for hot reload
LeeCheneler Dec 18, 2025
58db679
chore: bump version to 0.7.1
LeeCheneler Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bundler/ssr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,9 @@ export async function bundleSSR(
sourcemap: false,
write: false,
plugins: [...denoPlugins(hasConfig ? { configPath } : {})],
// Mark preact as external - we want the same instance as parent
external: ["preact", "preact/*", "preact-render-to-string"],
// Note: preact is bundled (not external) because the temp bundle file
// is outside the project's import map context and can't resolve preact.
// This is fine for SSR since we're just rendering to string.
});

try {
Expand Down
2 changes: 1 addition & 1 deletion deno.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@tabirun/pages",
"version": "0.7.0",
"version": "0.7.1",
"license": "MIT",
"nodeModulesDir": "auto",
"compilerOptions": {
Expand Down