fix(bundler): resolve preact import in SSR bundles#73
Merged
Conversation
Replaces the subprocess-per-request architecture with esbuild-based SSR bundling to bypass Deno's module cache. This eliminates: - Subprocess spawn overhead (50-200ms per request) - Shiki highlighter reinitialization (200-500ms first render) - Redundant page scanning (subprocess rescanned on each request) The new approach: 1. Generates SSR entry code that imports page + layout components 2. Bundles with esbuild (reads fresh files from disk) 3. Writes to unique temp file (bypasses Deno's import cache) 4. Imports and executes to get fresh components 5. Renders in parent process (keeps Shiki warm) Measured improvement: 600-1200ms -> 150-330ms per page render. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
LeeCheneler
force-pushed
the
feat/ssr-bundling-dev-perf
branch
from
e69b2bb to
58db679
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SSR bundling error when used from JSR:
Root cause: The SSR bundle marked
preactas external, but when Deno imports the temp bundle file, it can't resolvepreact/jsx-runtimebecause the temp file is outside the project's import map context.Fix: Bundle preact into the SSR output instead of marking it external. This is fine for SSR since we're just rendering to string and don't need hook state persistence across renders.
Also includes a timing fix for esbuild cleanup to prevent subprocess leaks in tests.
Test plan
🤖 Generated with Claude Code