fix: ensure config loading happens sequentially#3084
Merged
Conversation
🦋 Changeset detectedLatest commit: 54aac3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
elliott-with-the-longest-name-on-github
approved these changes
Jul 25, 2026
elliott-with-the-longest-name-on-github
merged commit Jul 25, 2026
62b980f
into
master
3 checks passed
Merged
Rich-Harris
added a commit
to sveltejs/kit
that referenced
this pull request
Jul 25, 2026
The other side of sveltejs/language-tools#3084. This fixes a case where `svelte-check` sometimes fails by reading multiple Vite configs in the same process, getting the `root` mixed up between them Either fix should prevent `svelte-check` raciness, but both should be applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current mechanism for ensuring that config loading is sequential is buggy — it's possible for multiple invocations to await the same
resolvingpromise. This, in turn, causes module-level state in the SvelteKit Vite plugin to get corrupted. That bug should be fixed as well as this one