fix: resolve root per instance of the SvelteKit Vite plugin#16513
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/875307f5788995f4bc0a06771d552076cd5aa448Open in |
🦋 Changeset detectedLatest commit: 875307f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
commented
Jul 25, 2026
|
|
||
| const message = | ||
| `\n${styleText(['bold', 'red'], path.relative(root, filename))}\n` + | ||
| `\n${styleText(['bold', 'red'], path.relative(process.cwd(), filename))}\n` + |
Member
Author
There was a problem hiding this comment.
Making paths relative to process.cwd() is more appropriate, since that way printed filenames stay cmd-clickable
Rich-Harris
commented
Jul 25, 2026
| if (basename.startsWith('+layout.') && !has_children(content, true)) { | ||
| const message = | ||
| `\n${styleText(['bold', 'red'], path.relative(root, filename))}\n` + | ||
| `\n${styleText(['bold', 'red'], path.relative(process.cwd(), filename))}\n` + |
Member
Author
There was a problem hiding this comment.
Rich-Harris
commented
Jul 25, 2026
teemingc
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The other side of sveltejs/language-tools#3084. This fixes a case where
svelte-checksometimes fails by reading multiple Vite configs in the same process, getting therootmixed up between themEither fix should prevent
svelte-checkraciness, but both should be applied.