Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/plenty-camels-shave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

perf: build transport encoders once instead of on every response
10 changes: 5 additions & 5 deletions packages/kit/src/runtime/server/page/actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { HttpError, Redirect, ActionFailure, SvelteKitError } from '@sveltejs/ki
import { with_request_store, merge_tracing } from '@sveltejs/kit/internal/server';
import { normalize_error } from '../../../utils/error.js';
import { is_form_content_type, negotiate } from '../../../utils/http.js';
import { create_replacer } from '../utils.js';
import { create_replacer, get_encoders } from '../utils.js';
import { handle_error_and_jsonify } from '../errors.js';
import { record_span } from '../../telemetry/record_span.js';

Expand Down Expand Up @@ -329,11 +329,11 @@ export function uneval_action_response(data, route_id, transport) {
* @param {ServerHooks['transport']} transport
*/
function stringify_action_response(data, route_id, transport) {
const encoders = Object.fromEntries(
Object.entries(transport).map(([key, value]) => [key, value.encode])
return try_serialize(
data,
(value) => devalue.stringify(value, get_encoders(transport)),
route_id
);

return try_serialize(data, (value) => devalue.stringify(value, encoders), route_id);
}

/**
Expand Down
6 changes: 2 additions & 4 deletions packages/kit/src/runtime/server/page/data_serializer.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as devalue from 'devalue';
import { compact } from '../../../utils/array.js';
import { create_async_iterator } from '../../../utils/streaming.js';
import { clarify_devalue_error, get_global_name, serialize_uses } from '../utils.js';
import { clarify_devalue_error, get_encoders, get_global_name, serialize_uses } from '../utils.js';
import { handle_error_and_jsonify } from '../errors.js';

/**
Expand Down Expand Up @@ -135,9 +135,7 @@ export function server_data_serializer_json(event, event_state, options) {
const iterator = create_async_iterator();

const reducers = {
...Object.fromEntries(
Object.entries(options.hooks.transport).map(([key, value]) => [key, value.encode])
),
...get_encoders(options.hooks.transport),
/** @param {any} thing */
Promise: (thing) => {
if (typeof thing?.then !== 'function') {
Expand Down
18 changes: 18 additions & 0 deletions packages/kit/src/runtime/server/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,24 @@ export function count_non_ssi_comments(str) {
return (str.match(/<!--(?!#)/g) ?? []).length;
}

/** @type {WeakMap<ServerHooks['transport'], Record<string, (value: any) => any>>} */
const encoders = new WeakMap();

/**
* Derives the devalue encoders from the app's transport hook, once per transport object
* @param {ServerHooks['transport']} transport
*/
export function get_encoders(transport) {
let cached = encoders.get(transport);
if (cached === undefined) {
cached = Object.fromEntries(
Object.entries(transport).map(([key, value]) => [key, value.encode])
);
encoders.set(transport, cached);
}
return cached;
}

/**
* Creates a serialiser for non-arbitrary POJOs using the app's transport hook
* @param {ServerHooks['transport']} transport
Expand Down
Loading