perf: build transport encoders once instead of on every response#16406
Open
Nic-Polumeyv wants to merge 2 commits into
Open
perf: build transport encoders once instead of on every response#16406Nic-Polumeyv wants to merge 2 commits into
Nic-Polumeyv wants to merge 2 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/ce4cf1dee77b10097723d1bc70c9d388d755a88bOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: ce4cf1d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Nic-Polumeyv
marked this pull request as ready for review
July 18, 2026 15:32
…ransport-encoders # Conflicts: # packages/kit/src/runtime/server/page/actions.js # packages/kit/src/runtime/server/page/data_serializer.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The encode map derived from the
transporthook was rebuilt on every serialized response, inserver_data_serializer_json(every__data.jsonrequest, plus SSR page renders that stream data) and instringify_action_response(every form action JSON response). The map only depends on the transport hook, which is fixed at server init, and init already builds the mirrordecodersmap exactly once inruntime/server/index.js. This moves the encode map into aget_encodershelper next tocreate_replacer, memoized per transport object with a WeakMap so dev-mode re-inits stay safe.The
unevalpaths are untouched sincecreate_replaceralready iterates the transport lazily. The per-request spread inserver_data_serializer_jsonstays because thePromisereducer closes over per-request state.No new test, the existing
serialization-*suites in the basics app cover both paths.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits