Skip to content

perf: build transport encoders once instead of on every response#16406

Open
Nic-Polumeyv wants to merge 2 commits into
sveltejs:version-3from
Nic-Polumeyv:perf-memoize-transport-encoders
Open

perf: build transport encoders once instead of on every response#16406
Nic-Polumeyv wants to merge 2 commits into
sveltejs:version-3from
Nic-Polumeyv:perf-memoize-transport-encoders

Conversation

@Nic-Polumeyv

Copy link
Copy Markdown
Contributor

The encode map derived from the transport hook was rebuilt on every serialized response, in server_data_serializer_json (every __data.json request, plus SSR page renders that stream data) and in stringify_action_response (every form action JSON response). The map only depends on the transport hook, which is fixed at server init, and init already builds the mirror decoders map exactly once in runtime/server/index.js. This moves the encode map into a get_encoders helper next to create_replacer, memoized per transport object with a WeakMap so dev-mode re-inits stay safe.

The uneval paths are untouched since create_replacer already iterates the transport lazily. The per-request spread in server_data_serializer_json stays because the Promise reducer closes over per-request state.

No new test, the existing serialization-* suites in the basics app cover both paths.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 18, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from ce4cf1d:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/ce4cf1dee77b10097723d1bc70c9d388d755a88b

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16406

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ce4cf1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Nic-Polumeyv
Nic-Polumeyv marked this pull request as ready for review July 18, 2026 15:32
…ransport-encoders

# Conflicts:
#	packages/kit/src/runtime/server/page/actions.js
#	packages/kit/src/runtime/server/page/data_serializer.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant