Ship the vendored Waymo Apache-2.0 license in the wheel/sdist (Apache §4a)#16
Merged
Merged
Conversation
The built wheel/sdist redistributed the vendored Waymo Open Dataset sources (standard_e2e/third_party/waymo_open_dataset/*.py) but did not include a copy of the Apache License 2.0. Apache-2.0 §4(a) requires giving recipients a copy of the License when redistributing the code, so the published artifact was non-compliant even though the source tree (isolated third_party/ dir, full Apache text, retained file headers) was fine. Bundle the project license, the third-party notice, and the vendored Apache 2.0 text into the distribution via PEP 639 [project] license-files, and also install the Apache text beside the vendored sources via package-data so it survives in site-packages. Modernize the license metadata to an SPDX expression and drop the now-deprecated trove classifier, and raise the setuptools floor to >=77 so the build is warning-free. Add an Apache attribution header to the derived numpy lidar decode that re-implements the upstream Waymo decode algorithm.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
stepankonev
added a commit
that referenced
this pull request
Jun 2, 2026
nuplan-devkit was git-pinned to v1.2 (not published on PyPI), so the released wheel could not be `pip install`-ed for NAVSIM: the [tool.uv.sources] git override does not propagate into wheel metadata, and a bare `nuplan-devkit` requirement resolved to the wrong PyPI version. nuplan-devkit 2.0.0 is on PyPI and is a drop-in for the small map API we use (get_maps_api, AbstractMap.get_proximal_map_objects, SemanticMapLayer, Point2D). Verified end-to-end: a NAVSIM segment reprocessed on 2.0.0 produces byte-identical HD-map output across all 398 frames versus the v1.2.0 git pin. Pin nuplan-devkit>=2.0.0,<3, drop the [tool.uv.sources] git override, and regenerate uv.lock so the dependency resolves from PyPI. With this, `pip install standard-e2e` works for all six dataset families. Bump the version to 0.0.4 to publish this together with the Apache-license packaging fix (#16); the immutable 0.0.3 keeps its gaps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The built wheel/sdist redistributes the vendored Waymo Open Dataset sources under
standard_e2e/third_party/waymo_open_dataset/but omits a copy of the Apache License 2.0. Apache-2.0 §4(a) requires giving recipients a copy of the License when redistributing the code, so the published artifact is non-compliant — even though the source tree itself is fine (vendored code isolated underthird_party/, full Apache text present, original per-file copyright headers retained).The cause is plain
setuptoolspackaging:packages.findships only.pyfiles, and there was noMANIFEST.in/license-files/package-datadirective, so theLICENSE(no extension) andTHIRD_PARTY_NOTICES.txtwere dropped from the build. (Waymo upstream ships noNOTICEfile, so Apache §4(c) does not apply.)Fix
[project] license-files.[tool.setuptools.package-data], so it survives insite-packagesnext to the code it governs.license = "MIT") and drop the now-deprecated MIT trove classifier; raise the setuptools floor to>=77. Together these keep the build warning-free under PEP 639.waymo_lidar_numpy.py, the numpy re-derivation of the upstream Waymo decode algorithm.Verification
Rebuilt wheel and sdist both contain all three license texts; the wheel
METADATAcarriesLicense-Expression: MITplus threeLicense-File:entries, and the build is warning-free.Note
PyPI releases are immutable, so the already-published
0.0.3retains the gap — this correction takes effect on the next version bump.