Skip to content

[WIP] add dev Dockerfile and entrypoint.sh#1

Open
stefsuse wants to merge 3 commits into
masterfrom
velum-dockerfile
Open

[WIP] add dev Dockerfile and entrypoint.sh#1
stefsuse wants to merge 3 commits into
masterfrom
velum-dockerfile

Conversation

@stefsuse

@stefsuse stefsuse commented Jan 4, 2019

Copy link
Copy Markdown
Owner

Move Docker configs from automation repo to velum.

Also fixes https://github.com/kubic-project/automation/issues/577

@stefsuse

stefsuse commented Jan 4, 2019

Copy link
Copy Markdown
Owner Author

This is a WIP. RUN statements were broken up as I worked through issues but the plan is to eventually squash all build steps back into one.
The first RUN that installs ruby etc will stay to take advantage of docker layer caching.

@stefsuse stefsuse changed the title add dev Dockerfile and entrypoint.sh [WIP] add dev Dockerfile and entrypoint.sh Jan 4, 2019
@changpil

changpil commented Jan 4, 2019

Copy link
Copy Markdown

if [[ $(basename $IMAGE) =~ [Kk]ubic ]]; then
IMAGE_DIST=kubic
RUBY_VERSION=ruby2.5
else
IMAGE_DIST=sles12
RUBY_VERSION=ruby2.1
fi
There are two options for ruby versions in automation/caasp-kvm/tools/build-velum-image.
Dockerfile has a static ruby version Does it have a backward compatibility for kubic image for bundler?

@stefsuse

stefsuse commented Jan 4, 2019

Copy link
Copy Markdown
Owner Author

if [[ $(basename $IMAGE) =~ [Kk]ubic ]]; then
IMAGE_DIST=kubic
RUBY_VERSION=ruby2.5
else
IMAGE_DIST=sles12
RUBY_VERSION=ruby2.1
fi
There are two options for ruby versions in automation/caasp-kvm/tools/build-velum-image.
Dockerfile has a static ruby version Does it have a backward compatibility for kubic image for bundler?

Correct, I did remove that because I separated out the Dockerfile and I am honestly not sure if kubic is built using this set of scripts anyhow. If it is I could update the Dockerfile to take an ARG, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants