You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a WIP. RUN statements were broken up as I worked through issues but the plan is to eventually squash all build steps back into one.
The first RUN that installs ruby etc will stay to take advantage of docker layer caching.
stefsuse
changed the title
add dev Dockerfile and entrypoint.sh
[WIP] add dev Dockerfile and entrypoint.sh
Jan 4, 2019
if [[ $(basename $IMAGE) =~ [Kk]ubic ]]; then
IMAGE_DIST=kubic
RUBY_VERSION=ruby2.5
else
IMAGE_DIST=sles12
RUBY_VERSION=ruby2.1
fi
There are two options for ruby versions in automation/caasp-kvm/tools/build-velum-image.
Dockerfile has a static ruby version Does it have a backward compatibility for kubic image for bundler?
if [[ $(basename $IMAGE) =~ [Kk]ubic ]]; then
IMAGE_DIST=kubic
RUBY_VERSION=ruby2.5
else
IMAGE_DIST=sles12
RUBY_VERSION=ruby2.1
fi
There are two options for ruby versions in automation/caasp-kvm/tools/build-velum-image.
Dockerfile has a static ruby version Does it have a backward compatibility for kubic image for bundler?
Correct, I did remove that because I separated out the Dockerfile and I am honestly not sure if kubic is built using this set of scripts anyhow. If it is I could update the Dockerfile to take an ARG, I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Docker configs from automation repo to velum.
Also fixes https://github.com/kubic-project/automation/issues/577