[WIP] fixes issue #577. other goal: build velum image with one dockerfile#1
Open
stefsuse wants to merge 2 commits into
Open
[WIP] fixes issue #577. other goal: build velum image with one dockerfile#1stefsuse wants to merge 2 commits into
stefsuse wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The end result of the docker build, velum-development.tar, should be the same but there are some important differences in how it gets built.
Old way:
pull image from registry.suse.de (defined by kiwi spec in H:Cn)
run a container from this image, mounts the velum source directory as a volume, run bundler build, then commit these changes to a WIP image
run a container from updated image to update schema file and commit
run a container from updated image to add environment variables and commit to final development image
save image tar to disk
New way:
if not using cache, move to Velum development directory and run docker build. The Dockerfile copies the required code into the container instead of relying on mounts.
save image tar to disk
if using cache, log message and exit