apollo_committer: test new edge bottom in witnesses

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

• apollo_committer: test new edge bottom in witnesses #14388 👈 (View in Graphite)
• apollo_committer: add request_paths_and_commit_block tests #14208
• starknet_patricia: add storage proof verification #14296
• apollo_committer: add new request handler #14003
• starknet_committer: delete patricia paths on reverts #14002
• starknet_committer,apollo_committer: add timers for fetch patricia paths #14189
• starknet_committer: underlying logic of the new read witnesses and commit endpoint #14001
• starknet_committer: extract metadata construction to a function #14000
• starknet_committer: extract commit plan to commit_or_load #13999
• starknet_committer: read and write patricia paths to index db #13998
• apollo_committer_types: add patricia proofs request and response types #13996 : 1 other dependent PR (#13997 )
• starknet_committer: add patricia paths forest reader/writer traits #13995
• starknet_committer: define StarknetForestProofs serde #13994
• starknet_committer: compute and store accessed keys digest #13993
• starknet_committer: add utility that returns sorted leaf indices #13992
• starknet_committer: abstract fetch_all_patricia_paths #13991
• starknet_patricia_storage: two layer storage #13990
• starknet_committer: move fetch_patricia_paths tests #13960
• starknet_committer: fetch patricia paths tests #13959
• starknet_committer: support both layouts in fetch_patricia_paths #13958
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Test-only change with no production or witness logic modifications.

Overview
Adds a regression test in request_paths_and_commit_block_tests.rs for Patricia witness generation when a class leaf is removed via read_paths_and_commit_block.

The scenario commits three class leaves (left pair A/B and rightmost D), then deletes D while requesting witnesses only for that key. It asserts classes_trie_proof includes the hash of inner node E (the binary parent of A and B)—the bottom of a new edge into an otherwise unchanged subtree.

Supporting imports only: PATRICIA_KEY_UPPER_BOUND_FELT for the rightmost key, plus BinaryData / NodeData to compute E’s expected node hash.

^{Reviewed by Cursor Bugbot for commit 523092c. Bugbot is set up for automated code reviews on this repo. Configure here.}

[yoavGrs]

@yoavGrs made 2 comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on ArielElp).

---

a discussion (no related file):
Can you reuse utils in crates/starknet_committer/src/forest/deleted_nodes_test.rs?

---

crates/apollo_committer/src/request_paths_and_commit_block_tests.rs line 484 at r1 (raw file):

        response.patricia_proofs.classes_trie_proof.contains_key(&edge_tree_node_e_hash),
        "missing bottom of a new edge node in a proof",
    );

Use your new storage proof verification?

Code quote:

    assert!(
        response.patricia_proofs.classes_trie_proof.contains_key(&edge_tree_node_e_hash),
        "missing bottom of a new edge node in a proof",
    );

[ArielElp]

@ArielElp made 2 comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on yoavGrs).

---

a discussion (no related file):

Previously, yoavGrs wrote…

Can you reuse utils in crates/starknet_committer/src/forest/deleted_nodes_test.rs?

Hhhmm doesn't look like it, in addition to being a bit higher level on ApolloCommitter it's testing different things. I don't really care about the deleted nodes on the right side.

---

crates/apollo_committer/src/request_paths_and_commit_block_tests.rs line 484 at r1 (raw file):

Previously, yoavGrs wrote…

Use your new storage proof verification?

To what leaf? I think the point here is that this case does not add "full paths" to the proof.

[yoavGrs]

@yoavGrs made 1 comment and resolved 2 discussions.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on ArielElp).

---

crates/apollo_committer/src/request_paths_and_commit_block_tests.rs line 421 at r1 (raw file):

    let class_hash_a = ClassHash(0_u64.into());
    let class_hash_b = ClassHash(1_u64.into());
    let class_hash_d = ClassHash(PATRICIA_KEY_UPPER_BOUND_FELT - 1_u64);

Please add another case where this key is 3 or 4:

1. To match the illustration.
2. In this case, the proof should contain a and b, right?

Code quote:

PATRICIA_KEY_UPPER_BOUND_FELT - 1_u64

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on ArielElp).

---

crates/apollo_committer/src/request_paths_and_commit_block_tests.rs line 383 at r3 (raw file):

/// 2. Commit block 1 via [crate::committer::Committer::read_paths_and_commit_block], deleting `D`
///    and requesting witnesses only for the deleted key.
/// 3. Assert the returned classes-trie proof contains node `E`.

we actually need A and B here as well, to prove E is binary when converting R to an edge from R to E

Code quote:

Assert the returned classes-trie proof contains node `E`.

---

crates/apollo_committer/src/request_paths_and_commit_block_tests.rs line 452 at r3 (raw file):

        response.patricia_proofs.classes_trie_proof.contains_key(&edge_tree_node_e_hash),
        "missing bottom of a new edge node in a proof",
    );

also assert leaf_a_hash and leaf_b_hash

Code quote:

    assert!(
        response.patricia_proofs.classes_trie_proof.contains_key(&edge_tree_node_e_hash),
        "missing bottom of a new edge node in a proof",
    );