apollo_committer: add request_paths_and_commit_block tests

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

• apollo_committer: reduce tests boilerplate #14425
• apollo_committer: test new edge bottom in witnesses #14388
• apollo_committer: add request_paths_and_commit_block tests #14208 👈 (View in Graphite)
• starknet_patricia: add storage proof verification #14296
• apollo_committer: add new request handler #14003
• starknet_committer: delete patricia paths on reverts #14002
• starknet_committer,apollo_committer: add timers for fetch patricia paths #14189
• starknet_committer: underlying logic of the new read witnesses and commit endpoint #14001
• starknet_committer: extract metadata construction to a function #14000
• starknet_committer: extract commit plan to commit_or_load #13999
• starknet_committer: read and write patricia paths to index db #13998
• apollo_committer_types: add patricia proofs request and response types #13996 : 1 other dependent PR (#13997 )
• starknet_committer: add patricia paths forest reader/writer traits #13995
• starknet_committer: define StarknetForestProofs serde #13994
• starknet_committer: compute and store accessed keys digest #13993
• starknet_committer: add utility that returns sorted leaf indices #13992
• starknet_committer: abstract fetch_all_patricia_paths #13991
• starknet_patricia_storage: two layer storage #13990
• starknet_committer: move fetch_patricia_paths tests #13960
• starknet_committer: fetch patricia paths tests #13959
• starknet_committer: support both layouts in fetch_patricia_paths #13958
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Test-only changes plus a gated test helper on MapStorage; no production committer or storage behavior is altered.

Overview
Adds integration tests for read_paths_and_commit_block behind the os_input feature, wired from committer_test.rs into a new request_paths_and_commit_block_tests module.

The happy-path test commits a block with AccessedKeys, checks returned Patricia proofs (classes, contracts, and per-contract storage) against trie roots, then uses a new IndexDb::clear_patricia_trie_nodes_for_test helper to strip trie nodes while keeping witness metadata and asserts a replay returns the same proofs from storage. A second test checks that revert drops the accessed-keys digest and persisted witness payload for the reverted height.

apollo_committer dev-dependencies now pull starknet_committer with the testing feature so the map-storage test hook is available.

^{Reviewed by Cursor Bugbot for commit 91077f1. Bugbot is set up for automated code reviews on this repo. Configure here.}

[dorimedini-starkware]

@dorimedini-starkware reviewed 5 files and all commit messages, made 1 comment, and resolved 6 discussions.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp).

---

crates/starknet_committer/src/db/index_db/db.rs line 504 at r8 (raw file):

Previously, ArielElp wrote…

I don't follow, let me add some context:

This test util is only used to verify that when we're re-sending the same request to the committer, it does not recompute. Ideally, this would have been done with nice mock libs, but I need too much of the real implementation to make it work. To overcome this, I'm simply removing all the trie data from the storage (keeping only metadata). If the request succeeds, then it clearly did not recompute.

can't this be a util in the test module though?

[ArielElp]

@ArielElp made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware).

---

crates/starknet_committer/src/db/index_db/db.rs line 504 at r8 (raw file):

Previously, dorimedini-starkware wrote…

can't this be a util in the test module though?

Nope, I need access to the underlying storage which the committer does not see

[dorimedini-starkware]

@dorimedini-starkware resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).

[ArielElp]

@ArielElp reviewed 4 files and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

[graphite-app]

Merge activity

• Jun 8, 2:02 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
• Jun 8, 2:03 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).