Skip to content

SYN-3601: Preserve certificates with nullable HTTP ports #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcsco merged 1 commit into from
Jul 23, 2026
Merged

SYN-3601: Preserve certificates with nullable HTTP ports #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions syntheticsclientv2/common_models.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,7 @@ type HttpCheckV2ResponseWithNullablePort struct {
Authentication *Authentication `json:"authentication"`
UserAgent *string `json:"userAgent"`
Verifycertificates bool `json:"verifyCertificates"`
CertificateID *NullableInt `json:"certificateId,omitempty"`
HttpHeaders []HttpHeaders `json:"headers,omitempty"`
Validations []Validations `json:"validations"`
Customproperties []CustomProperties `json:"customProperties"`
Expand All @@ -766,6 +767,7 @@ type HttpCheckV2InputWithNullablePort struct {
Authentication *Authentication `json:"authentication"`
UserAgent *string `json:"userAgent"`
Verifycertificates bool `json:"verifyCertificates"`
CertificateID *NullableInt `json:"certificateId,omitempty"`
HttpHeaders []HttpHeaders `json:"headers,omitempty"`
Validations []Validations `json:"validations"`
Customproperties []CustomProperties `json:"customProperties"`
Expand Down
26 changes: 24 additions & 2 deletions syntheticsclientv2/httpcheckv2_nullable_port_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,22 @@ func TestCreateHttpCheckV2WithNullablePortSendsNullPort(t *testing.T) {
if string(rawPort) != "null" {
t.Fatalf("request body test.port = %s, want null", rawPort)
}
_, err := w.Write([]byte(`{"test":{"id":11,"name":"nullable-port","type":"http","url":"https://example.com","requestMethod":"GET","port":null}}`))
rawCertificateID, ok := fields["certificateId"]
if !ok {
t.Fatal("request body missing test.certificateId")
}
if string(rawCertificateID) != "123" {
t.Fatalf("request body test.certificateId = %s, want 123", rawCertificateID)
}
_, err := w.Write([]byte(`{"test":{"id":11,"name":"nullable-port","type":"http","url":"https://example.com","requestMethod":"GET","port":null,"certificateId":123}}`))
if err != nil {
t.Fatal(err)
}
})

input := minimalHttpCheckV2InputWithNullablePort()
input.Test.Port = *NewNullInt()
input.Test.CertificateID = NewNullableInt(123)

resp, _, err := testClient.CreateHttpCheckV2WithNullablePort(&input)
if err != nil {
Expand All @@ -54,6 +62,9 @@ func TestCreateHttpCheckV2WithNullablePortSendsNullPort(t *testing.T) {
if resp.Test.Port.Value != nil {
t.Fatalf("response port = %#v, want nil", resp.Test.Port.Value)
}
if resp.Test.CertificateID == nil || resp.Test.CertificateID.Value == nil || *resp.Test.CertificateID.Value != 123 {
t.Fatalf("response certificate ID = %#v, want 123", resp.Test.CertificateID)
}
}

func TestUpdateHttpCheckV2WithNullablePortSendsZeroPort(t *testing.T) {
Expand All @@ -70,6 +81,13 @@ func TestUpdateHttpCheckV2WithNullablePortSendsZeroPort(t *testing.T) {
if string(rawPort) != "0" {
t.Fatalf("request body test.port = %s, want 0", rawPort)
}
rawCertificateID, ok := fields["certificateId"]
if !ok {
t.Fatal("request body missing test.certificateId")
}
if string(rawCertificateID) != "null" {
t.Fatalf("request body test.certificateId = %s, want null", rawCertificateID)
}
_, err := w.Write([]byte(`{"test":{"id":12,"name":"nullable-port","type":"http","url":"https://example.com","requestMethod":"GET","port":0}}`))
if err != nil {
t.Fatal(err)
Expand All @@ -78,6 +96,7 @@ func TestUpdateHttpCheckV2WithNullablePortSendsZeroPort(t *testing.T) {

input := minimalHttpCheckV2InputWithNullablePort()
input.Test.Port = *NewNullableInt(0)
input.Test.CertificateID = NewNullInt()

resp, _, err := testClient.UpdateHttpCheckV2WithNullablePort(12, &input)
if err != nil {
Expand All @@ -102,7 +121,7 @@ func TestGetHttpCheckV2WithNullablePortPreservesNullAndValue(t *testing.T) {
},
{
name: "value",
body: `{"test":{"id":13,"name":"nullable-port","type":"http","url":"https://example.com","requestMethod":"GET","port":443}}`,
body: `{"test":{"id":13,"name":"nullable-port","type":"http","url":"https://example.com","requestMethod":"GET","port":443,"certificateId":123}}`,
wantValue: 443,
},
}
Expand Down Expand Up @@ -133,6 +152,9 @@ func TestGetHttpCheckV2WithNullablePortPreservesNullAndValue(t *testing.T) {
if resp.Test.Port.Value == nil || *resp.Test.Port.Value != tt.wantValue {
t.Fatalf("response port = %#v, want %d", resp.Test.Port.Value, tt.wantValue)
}
if resp.Test.CertificateID == nil || resp.Test.CertificateID.Value == nil || *resp.Test.CertificateID.Value != 123 {
t.Fatalf("response certificate ID = %#v, want 123", resp.Test.CertificateID)
}
})
}
}
Expand Down
Loading