Skip to content

SYN-3601: Preserve certificates with nullable HTTP ports#48

Merged
jcsco merged 1 commit into
v2from
agent/syn-3601-nullable-port-certificates
Jul 23, 2026
Merged

SYN-3601: Preserve certificates with nullable HTTP ports#48
jcsco merged 1 commit into
v2from
agent/syn-3601-nullable-port-certificates

Conversation

@jcsco

@jcsco jcsco commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Preserves HTTP V2 client-certificate support when callers use the existing nullable-port request and response models.

Problem

HttpCheckV2Input and HttpCheckV2Response include certificateId, while HttpCheckV2InputWithNullablePort and HttpCheckV2ResponseWithNullablePort do not. The Terraform provider must use the nullable-port models to represent an omitted HTTP port separately from an explicit 0. Without this change, adopting those models for SYN-3601 would silently omit or lose the HTTP client-certificate association added by SYN-5402.

Changes

  • Add certificateId to HttpCheckV2InputWithNullablePort.
  • Add certificateId to HttpCheckV2ResponseWithNullablePort.
  • Verify create serializes a configured certificate ID.
  • Verify update serializes explicit null for certificate removal.
  • Verify get parses the certificate ID alongside nullable port values.

Compatibility

This is additive and preserves the existing JSON field name and nullable semantics. Existing callers that do not set a certificate ID are unchanged.

Validation

  • go test ./... -tags=unit_tests -count=1 -timeout=60s
  • go vet -tags=unit_tests ./...
  • go build -tags=unit_tests ./...
  • golangci-lint run ./syntheticsclientv2/...
  • git diff --check

Related

@jcsco jcsco self-assigned this Jul 22, 2026
@jcsco
jcsco marked this pull request as ready for review July 23, 2026 00:57
@jcsco
jcsco merged commit ca5a112 into v2 Jul 23, 2026
4 checks passed
@jcsco
jcsco deleted the agent/syn-3601-nullable-port-certificates branch July 23, 2026 15:36
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants