SYN-3601: Preserve certificates with nullable HTTP ports#48
Merged
Conversation
bchhay-splunk
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves HTTP V2 client-certificate support when callers use the existing nullable-port request and response models.
Problem
HttpCheckV2InputandHttpCheckV2ResponseincludecertificateId, whileHttpCheckV2InputWithNullablePortandHttpCheckV2ResponseWithNullablePortdo not. The Terraform provider must use the nullable-port models to represent an omitted HTTP port separately from an explicit0. Without this change, adopting those models for SYN-3601 would silently omit or lose the HTTP client-certificate association added by SYN-5402.Changes
certificateIdtoHttpCheckV2InputWithNullablePort.certificateIdtoHttpCheckV2ResponseWithNullablePort.nullfor certificate removal.Compatibility
This is additive and preserves the existing JSON field name and nullable semantics. Existing callers that do not set a certificate ID are unchanged.
Validation
go test ./... -tags=unit_tests -count=1 -timeout=60sgo vet -tags=unit_tests ./...go build -tags=unit_tests ./...golangci-lint run ./syntheticsclientv2/...git diff --checkRelated