ci: use Spicepod v2 in the test fixture - #315
Open
lukekim wants to merge 2 commits into
Open
Conversation
test/scripts/spicepod.yaml declared `version: v1beta1`, which current spiced rejects outright: Failed to start Spice runtime: Unable to load spicepod .../test/scripts: Unsupported Spicepod version in .../test/scripts: 'v1beta1' Supported versions are: v1, v2 With no spicepod loaded the runtime never serves, so every Local Runtime test fails on ECONNREFUSED to 127.0.0.1:8090. This affects every open PR, not any one change. Verified locally: with `version: v1` the runtime loads both datasets and starts serving.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
v2 is what `spice init` emits, so the fixture now matches what the CLI generates rather than trailing it. Verified locally: spiced loads the fixture unchanged under v2 — both datasets dispatch and the runtime serves. No schema migration was needed.
|
The six red Evidence:
I can't rerun it myself ( Worth clearing — #314 is waiting on this one to merge, and its own CI is separately parked at |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changes
version: v1beta1toversion: v2intest/scripts/spicepod.yaml. One line.Why
Current
spicedrejectsv1beta1outright:With no spicepod loaded the runtime never starts serving, so every
Local Runtimetest fails withconnect ECONNREFUSED 127.0.0.1:8090— 15 failed / 3 passed per matrix entry.This is repo-wide, not specific to any change: PRs #311, #312 and #313 all fail identically. It's version drift between the fixture and the installed runtime, which will keep every PR red until it's fixed.
Verification
Ran
spicedlocally against the amended fixture (verified under bothv1andv2;v2is whatspice initemits, so the fixture now matches the CLI rather than trailing it). TheUnsupported Spicepod versionerror is gone, both datasets are picked up, and the runtime serves:Both datasets then fail to connect to PostgreSQL, which is expected — there's no postgres on this machine. CI provides one via its
services:block, so that part is exercised there.Deliberately scoped to the one line; no other fixture or workflow changes.