ci: move the test Spicepod off the removed v1beta1 version - #314
ci: move the test Spicepod off the removed v1beta1 version#314claudespice wants to merge 1 commit into
Conversation
The runtime dropped v1beta1 as a valid Spicepod version, so spiced refuses
to start against test/scripts/spicepod.yaml:
Failed to start Spice runtime: Unable to load spicepod test/scripts:
Unsupported Spicepod version in test/scripts: 'v1beta1'
Supported versions are: v1, v2
Because the runtime never comes up, every Local Runtime test fails on
ECONNREFUSED to 127.0.0.1:8090 and gRPC UNAVAILABLE rather than on anything
it was written to assert. That makes the whole suite red on every open PR
regardless of its contents.
The Spicepod body is already v1-shaped, so the version string is the only
change needed.
|
@claudespice is attempting to deploy a commit to the Spice AI Team on Vercel. A member of the Team first needs to authorize it. |
|
@copilot review Note for a maintainer: CI here is gated on Verified without CI in the meantime: the runtime error itself enumerates the accepted values ( |
|
Superseded by #315 — closing this once that merges. #315 ( Both versions are valid — |
Every open PR in this repo is red on
Local Runtime, and none of them caused it.Cause
test/scripts/spicepod.yamlstill declaresversion: v1beta1. The runtime removed that version, sospicedrefuses to start at all:Because the runtime never comes up, the tests fail on transport errors rather than on anything they assert —
connect ECONNREFUSED 127.0.0.1:8090for the HTTP calls and14 UNAVAILABLE: No connection establishedfor Flight. The reported failures (expect(isHealthy).toBe(true),expect(isReady).toBe(true)) are symptoms of a dead runtime, which is why the error is easy to misread as a product regression.Confirmed repo-wide, not branch-specific: it fails identically on #311, on lukekim's #313, and on dependabot #306 — a pure dependency bump that touches no source at all.
Fix
The Spicepod body is already
v1-shaped, so the version string is the only change.v1also matches the convention used across the runtime repo's own test Spicepods.Not addressed here
Two other checks are red for reasons outside this repo's control, and this PR deliberately leaves them alone:
Cloud Tests—SPICEAI_API_KEYandSCP_SPICEAI_TPCH_API_KEYarrive empty (Secret source: None), because GitHub withholds repo secrets from fork PRs.Vercel—Authorization required to deploy, same fork-secret restriction.