Skip to content

MNT: Remove deprecated gfit and nmpfit#108

Closed
pllim wants to merge 1 commit into
spacetelescope:masterfrom
pllim:rm-nmpfit
Closed

MNT: Remove deprecated gfit and nmpfit#108
pllim wants to merge 1 commit into
spacetelescope:masterfrom
pllim:rm-nmpfit

Conversation

@pllim

@pllim pllim commented Apr 1, 2020

Copy link
Copy Markdown
Contributor

@pllim pllim requested review from nden and stscirij April 1, 2020 21:15
@nden

nden commented Apr 1, 2020

Copy link
Copy Markdown
Contributor

nmpfit cannot be removed before mktrace is replaced with astropy.modeling.

@pllim

pllim commented Apr 2, 2020

Copy link
Copy Markdown
Contributor Author

That is unfortunate. @nden , what can I do to move this forward?

@pllim pllim modified the milestones: 4.0, 3.7 Apr 2, 2020
@nden

nden commented Apr 2, 2020

Copy link
Copy Markdown
Contributor

@pllim As I said spacetelescope/stistools#37 needs to be resolved first. At the time it was waiting on reworking the regression tests. I'm not sure what the current situation is.

@pllim

pllim commented Apr 16, 2020

Copy link
Copy Markdown
Contributor Author

I'll resolve conflict when this gets an okay to move ahead.

@pllim pllim modified the milestones: 3.7, 4.0 Apr 20, 2020
@pllim

pllim commented Aug 11, 2021

Copy link
Copy Markdown
Contributor Author

This now has conflicts and I lost interest to work on it. So I am closing this PR.

@pllim pllim closed this Aug 11, 2021
@pllim pllim deleted the rm-nmpfit branch August 11, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove nmpfit in v 3.5

2 participants