Skip to content

API: Remove deprecated nmpfit and gfit#190

Closed
pllim wants to merge 1 commit into
spacetelescope:mainfrom
pllim:rm-nmpfit
Closed

API: Remove deprecated nmpfit and gfit#190
pllim wants to merge 1 commit into
spacetelescope:mainfrom
pllim:rm-nmpfit

Conversation

@pllim

@pllim pllim commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

Description

This pull request is to:

I cannot add a change log because change log is outdated, see #188

@pllim

pllim commented Jan 12, 2026

Copy link
Copy Markdown
Contributor Author

Oh wait, looks like I tried 5 years ago but Nadia said I couldn't remove it: #108 (comment)

Did "mktrace is replaced with astropy.modeling" ever happen?

@pllim

pllim commented Jan 12, 2026

Copy link
Copy Markdown
Contributor Author

Oh no, spacetelescope/stistools#37 is still open.

@pllim pllim requested a review from mcara January 12, 2026 22:49
@mcara

mcara commented Jan 12, 2026

Copy link
Copy Markdown
Member

Looks liKe @stscirij never approved that PR 😆

@pllim

pllim commented Jan 14, 2026

Copy link
Copy Markdown
Contributor Author

I guess I will close this since we can't really do it still :(

@pllim pllim closed this Jan 14, 2026
@pllim pllim deleted the rm-nmpfit branch January 14, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove nmpfit in v 3.5 Setting shape attribute directly is deprecated in numpy

2 participants