[fpmsyncd]: add libnexthopgroup in Makefile.am to support rib/fib - #4394
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
LARLSN
force-pushed
the
dev-ribfib-libnexthopgroup
branch
from
May 21, 2026 05:55
980763d to
fac9c4c
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ture Signed-off-by: linsongnan <linsongnan.lsn@alibaba-inc.com>
LARLSN
force-pushed
the
dev-ribfib-libnexthopgroup
branch
from
May 21, 2026 08:36
fac9c4c to
d0d61c4
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Add libnexthopgroup deb package from sonic-buildimage common_libs as both a compile-time and runtime dependency for VS test docker. Signed-off-by: linsongnan <linsongnan.lsn@alibaba-inc.com>
LARLSN
force-pushed
the
dev-ribfib-libnexthopgroup
branch
from
May 21, 2026 11:23
4d0d749 to
40cbaf1
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
eddieruan-alibaba
approved these changes
May 21, 2026
prsunny
approved these changes
May 21, 2026
Closed
5 tasks
This was referenced Jun 9, 2026
prsunny
pushed a commit
that referenced
this pull request
Jun 10, 2026
…/fib (#4394)" (#4657) This reverts #4394. What I did Remove build dependency on libnexthopgroup to unblock CI failures. This lib is not actively used in SWSS at the moment. Why I did it sonic-net/sonic-buildimage#27629 is part of the libyang1 to libyang3 migration and causes libnexthopgroup to not be built as part of the common-libs pipeline. Previously when the migration was in progress, both libyang1 and 3 were being built. All packages which were dependent on libyang3 (including libnexthopgroup transitively via FRR) were built as part of common-libs due to some serialization logic to prevent libyang1 and 3 from conflicting in sonic-buildimage at build time. Now that libyang1 is completely removed, this serialization logic doesn't exist anymore and libnexthopgroup is not built as part of common-libs, which causes the SWSS build to fail since libnexthopgroup is missing.
yxieca-admin
pushed a commit
that referenced
this pull request
Jun 13, 2026
…/fib" (#4668) This reverts #4394. <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** Remove build dependency on libnexthopgroup to unblock CI failures. This lib is not actively used in SWSS at the moment. **Why I did it** sonic-net/sonic-buildimage#27629 is part of the libyang1 to libyang3 migration and causes libnexthopgroup to not be built as part of the common-libs pipeline. Previously when the migration was in progress, both libyang1 and 3 were being built. All packages which were dependent on libyang3 (including libnexthopgroup transitively via FRR) were built as part of common-libs due to some serialization logic to prevent libyang1 and 3 from conflicting in sonic-buildimage at build time. Now that libyang1 is completely removed, this serialization logic doesn't exist anymore and libnexthopgroup is not built as part of common-libs, which causes the SWSS build to fail since libnexthopgroup is missing. **How I verified it** **Details if related** Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Yogapriya-cisco
pushed a commit
to prhoskot/sonic-swss
that referenced
this pull request
Jul 13, 2026
…nic-net#4394) * [fpmsyncd]: add libnexthopgroup in Makefile.am to support rib/fib feature What I did Add libnexthopgroup in fpmsyncd Makefile.am to support RIB/FIB Why I did it In the RIB/FIB design, we need the libnexthopgroup compiled from sonic-fib to communicate with Zebra. More details please refer the documents following: RIB/FIB HLD: sonic-net/SONiC#2060 nhg mgr LLD: sonic-net/SONiC#2270 sonic-fib PR: sonic-net/SONiC#2270 RIB/FIB nhg mgr code: sonic-net#4395 Signed-off-by: Yogapriya Mohankumar <ymohanku@cisco.com>
Yogapriya-cisco
pushed a commit
to prhoskot/sonic-swss
that referenced
this pull request
Jul 13, 2026
…/fib (sonic-net#4394)" (sonic-net#4657) This reverts sonic-net#4394. What I did Remove build dependency on libnexthopgroup to unblock CI failures. This lib is not actively used in SWSS at the moment. Why I did it sonic-net/sonic-buildimage#27629 is part of the libyang1 to libyang3 migration and causes libnexthopgroup to not be built as part of the common-libs pipeline. Previously when the migration was in progress, both libyang1 and 3 were being built. All packages which were dependent on libyang3 (including libnexthopgroup transitively via FRR) were built as part of common-libs due to some serialization logic to prevent libyang1 and 3 from conflicting in sonic-buildimage at build time. Now that libyang1 is completely removed, this serialization logic doesn't exist anymore and libnexthopgroup is not built as part of common-libs, which causes the SWSS build to fail since libnexthopgroup is missing. Signed-off-by: Yogapriya Mohankumar <ymohanku@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add libnexthopgroup in fpmsyncd Makefile.am to support RIB/FIB
Why I did it
In the RIB/FIB design, we need the libnexthopgroup compiled from sonic-fib to communicate with Zebra.
More details please refer the documents following:
RIB/FIB HLD: sonic-net/SONiC#2060
nhg mgr LLD: sonic-net/SONiC#2270
sonic-fib PR: sonic-net/SONiC#2270
RIB/FIB nhg mgr code: #4395
How I verified it
Details if related