Re-add the libnexthopgroup to Azure pipeline build and swss Makefile.am - #4663
Closed
LARLSN wants to merge 2 commits into
Closed
Re-add the libnexthopgroup to Azure pipeline build and swss Makefile.am#4663LARLSN wants to merge 2 commits into
LARLSN wants to merge 2 commits into
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ture Signed-off-by: linsongnan <linsongnan.lsn@alibaba-inc.com>
LARLSN
force-pushed
the
dev-ribfib-libnexthopgroup
branch
from
June 12, 2026 01:38
bc5f64d to
ac1082f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
LARLSN
force-pushed
the
dev-ribfib-libnexthopgroup
branch
from
June 12, 2026 01:43
ac1082f to
ed9629f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
LARLSN
force-pushed
the
dev-ribfib-libnexthopgroup
branch
from
June 12, 2026 02:06
ed9629f to
38e9005
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
LARLSN
force-pushed
the
dev-ribfib-libnexthopgroup
branch
2 times, most recently
from
June 12, 2026 02:15
abfddff to
600c6ce
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
LARLSN
changed the title
LARLSN
changed the title
Contributor
Author
|
@theasianpianist , hi Lawrence, we've added the libnexthopgroup into pipeline and swss Makefile.am again. Could you help us to review this PR. |
Re-add libnexthopgroup deb package from sonic-buildimage common_libs. Signed-off-by: linsongnan <linsongnan.lsn@alibaba-inc.com>
LARLSN
force-pushed
the
dev-ribfib-libnexthopgroup
branch
from
June 12, 2026 08:45
600c6ce to
4e755fc
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Is there a reason we need a separate PR for the Makefile and CI changes? It would be better to add these changes to #4395 instead, it doesn't make sense to me to add these build dependencies any earlier than necessary. |
theasianpianist
requested changes
Jul 14, 2026
theasianpianist
left a comment
theasianpianist
left a comment
Contributor
There was a problem hiding this comment.
Is there a reason we need a separate PR for the Makefile and CI changes? It would be better to add these changes to #4395 instead, it doesn't make sense to me to add these build dependencies any earlier than necessary.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Re-add the libnexthopgroup to Azure pipeline build and Makefile.am to support rib/fib feature.
This pr was added before, but it was reverted for some reasons, and now it is added again.
The reasons for reverting can be found in PR: #4657
Previous PR: #4394
Why I did it
In the RIB/FIB design, we need the libnexthopgroup compiled from sonic-fib to communicate with Zebra.
More details please refer the documents following:
How I verified it
Unit tests for libnexthopgroup.
Unit tests for nhg mgr.
Daily vsonic tests.
Details if related