vslib/vpp: register hostif info for link-state updates#1870
Merged
yue-fred-gao merged 1 commit intoApr 30, 2026
Merged
Conversation
|
|
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yue-fred-gao
left a comment
yue-fred-gao
left a comment
Contributor
There was a problem hiding this comment.
Please create a sonic-buildimage PR with sonic-sairedis submodule pointing to this PR branch. That will trigger sonic-vpp t1-lag sanity. Please share the result to make sure it doesn't break sanity
| return SAI_STATUS_FAILURE; | ||
| } | ||
|
|
||
| if (!hostif_create_tap_veth_forwarding(name, tapfd, obj_id)) |
Contributor
There was a problem hiding this comment.
hostif_create_tap_veth_forwarding does a lot of things that are not needed for vpp. What you need is only register the interface in m_hostif_info_map. Can you remove the socket related code and rename the function pertaining to registering host interface in map?
| // std::string vname = vpp_get_veth_name(name, info->m_portId); | ||
| if (it != m_hostif_info_map.end()) | ||
| { | ||
| SWSS_LOG_NOTICE("attempting to remove host info entry for tap device: %s", name.c_str()); |
Contributor
There was a problem hiding this comment.
Please lower it to INFO
Signed-off-by: janpal23 <janapal.cisco@gmail.com>
janpal23
force-pushed
the
janpal/vpp-hostif-registration-for-link-events
branch
from
April 30, 2026 00:58
f3c80ca to
48a2d34
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yue-fred-gao
approved these changes
Apr 30, 2026
Collaborator
|
Cherry-pick PR to msft-202603: Azure/sonic-sairedis.msft#130 |
mssonicbld
added
Included in msft-202603 Branch
and removed
Created PR to msft-202603 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
On the VPP path, hostif creation did not populate
m_hostif_info_map. As a result, runtimeRTM_NEWLINKevents were dropped bysyncOnLinkMsg()becausehasIfIndex()could not match the interface, so no SAI port-state-change notification was sent andoper_statusin APPL_DB could remain stale.Fix
Call
hostif_create_tap_veth_forwarding(name, tapfd, obj_id)fromSwitchVpp::vs_create_hostif_tap_interface()and remove the matching hostif bookkeeping inSwitchVpp::vs_remove_hostif_tap_interface().