[action] [PR:1870] vslib/vpp: register hostif info for link-state updates#130
Merged
Merged
Conversation
## Summary - register VPP hostif info during hostif creation - allow runtime link events to match the hostif ifindex - clean up hostif bookkeeping on remove ## Problem On the VPP path, hostif creation did not populate `m_hostif_info_map`. As a result, runtime `RTM_NEWLINK` events were dropped by `syncOnLinkMsg()` because `hasIfIndex()` could not match the interface, so no SAI port-state-change notification was sent and `oper_status` in APPL_DB could remain stale. ## Fix Call `hostif_create_tap_veth_forwarding(name, tapfd, obj_id)` from `SwitchVpp::vs_create_hostif_tap_interface()` and remove the matching hostif bookkeeping in `SwitchVpp::vs_remove_hostif_tap_interface()`. Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Collaborator
Author
|
Original PR: sonic-net/sonic-sairedis#1870 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
On the VPP path, hostif creation did not populate
m_hostif_info_map. As a result, runtimeRTM_NEWLINKevents were dropped bysyncOnLinkMsg()becausehasIfIndex()could not match the interface, so no SAI port-state-change notification was sent andoper_statusin APPL_DB could remain stale.Fix
Call
hostif_create_tap_veth_forwarding(name, tapfd, obj_id)fromSwitchVpp::vs_create_hostif_tap_interface()and remove the matching hostif bookkeeping inSwitchVpp::vs_remove_hostif_tap_interface().Signed-off-by: Sonic Build Admin sonicbld@microsoft.com