chore(retry): AccessDeniedException inclusion in CLOCK_SKEW_ERROR_CODES#2145
Merged
Merged
Conversation
8 tasks
siddsriv
force-pushed
the
feat/clock-skew-sep-update
branch
from
July 14, 2026 18:15
e36f5d7 to
a3412fe
Compare
siddsriv
marked this pull request as ready for review
July 14, 2026 18:15
siddsriv
force-pushed
the
feat/clock-skew-sep-update
branch
2 times, most recently
from
July 20, 2026 17:23
9c896f3 to
333fa35
Compare
kuhe
reviewed
Jul 20, 2026
| "AuthFailure", | ||
| "InvalidSignatureException", | ||
| "RequestExpired", | ||
| "RequestInTheFuture", |
Contributor
There was a problem hiding this comment.
why remove these two? isn't the likelihood of RequestInTheFuture indicating clock skew pretty high?
Contributor
Author
There was a problem hiding this comment.
directly spec dictated
Contributor
Author
There was a problem hiding this comment.
re-added after discussion
siddsriv
force-pushed
the
feat/clock-skew-sep-update
branch
from
July 20, 2026 19:01
333fa35 to
4a2e417
Compare
siddsriv
force-pushed
the
feat/clock-skew-sep-update
branch
from
July 21, 2026 18:49
4a2e417 to
8d37423
Compare
aBurmeseDev
reviewed
Jul 21, 2026
aBurmeseDev
approved these changes
Jul 21, 2026
kuhe
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Internal JS-7004
Description of changes:
add
AccessDeniedExceptionas a retryable clock skew error.JSv3 change: aws/aws-sdk-js-v3#8189
If one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.