Skip to content

chore(retry): AccessDeniedException inclusion in CLOCK_SKEW_ERROR_CODES#2145

Merged
siddsriv merged 3 commits into
smithy-lang:mainfrom
siddsriv:feat/clock-skew-sep-update
Jul 23, 2026
Merged

chore(retry): AccessDeniedException inclusion in CLOCK_SKEW_ERROR_CODES#2145
siddsriv merged 3 commits into
smithy-lang:mainfrom
siddsriv:feat/clock-skew-sep-update

Conversation

@siddsriv

@siddsriv siddsriv commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Issue #, if available:
Internal JS-7004

Description of changes:
add AccessDeniedException as a retryable clock skew error.

JSv3 change: aws/aws-sdk-js-v3#8189

If one or more of the packages in the /packages directory has been modified, be sure yarn changeset add has been run and its output has
been committed and included in this pull request. See CONTRIBUTING.md.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@siddsriv
siddsriv force-pushed the feat/clock-skew-sep-update branch from e36f5d7 to a3412fe Compare July 14, 2026 18:15
@siddsriv
siddsriv marked this pull request as ready for review July 14, 2026 18:15
@siddsriv
siddsriv requested a review from a team as a code owner July 14, 2026 18:15
@siddsriv
siddsriv force-pushed the feat/clock-skew-sep-update branch 2 times, most recently from 9c896f3 to 333fa35 Compare July 20, 2026 17:23
"AuthFailure",
"InvalidSignatureException",
"RequestExpired",
"RequestInTheFuture",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove these two? isn't the likelihood of RequestInTheFuture indicating clock skew pretty high?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directly spec dictated

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-added after discussion

@siddsriv
siddsriv force-pushed the feat/clock-skew-sep-update branch from 333fa35 to 4a2e417 Compare July 20, 2026 19:01
@siddsriv
siddsriv force-pushed the feat/clock-skew-sep-update branch from 4a2e417 to 8d37423 Compare July 21, 2026 18:49
@siddsriv
siddsriv merged commit 155bb56 into smithy-lang:main Jul 23, 2026
14 checks passed
@siddsriv
siddsriv deleted the feat/clock-skew-sep-update branch July 23, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants