feat(core): update clock skew detection threshold and configs#8189
Merged
Conversation
siddsriv
force-pushed
the
feat/clock-skew-sep-update
branch
2 times, most recently
from
July 13, 2026 22:01
645ae10 to
ddbfde3
Compare
siddsriv
marked this pull request as ready for review
July 14, 2026 18:15
siddsriv
force-pushed
the
feat/clock-skew-sep-update
branch
from
July 16, 2026 19:46
97951a0 to
38e46ce
Compare
siddsriv
force-pushed
the
feat/clock-skew-sep-update
branch
from
July 17, 2026 22:15
38e46ce to
5b635ad
Compare
4 tasks
kuhe
requested changes
Jul 21, 2026
kuhe
reviewed
Jul 22, 2026
kuhe
reviewed
Jul 22, 2026
kuhe
reviewed
Jul 22, 2026
kuhe
reviewed
Jul 22, 2026
kuhe
reviewed
Jul 22, 2026
kuhe
reviewed
Jul 22, 2026
kuhe
reviewed
Jul 22, 2026
kuhe
reviewed
Jul 22, 2026
kuhe
reviewed
Jul 23, 2026
kuhe
reviewed
Jul 23, 2026
kuhe
reviewed
Jul 23, 2026
kuhe
reviewed
Jul 23, 2026
kuhe
reviewed
Jul 23, 2026
kuhe
reviewed
Jul 23, 2026
kuhe
reviewed
Jul 23, 2026
siddsriv
force-pushed
the
feat/clock-skew-sep-update
branch
from
July 23, 2026 18:36
04b42a3 to
30d8ff7
Compare
kuhe
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Internal JS-7004
Description
Some updates for clock skew/retry behavior:
disableClockSkewCorrectionNote that
disableClockSkewCorrectionconfig resolver lives inhttpAuthSchemes/aws_sdk/(alongside the signer that consumes it) rather than a new submodule, following theNODE_AUTH_SCHEME_PREFERENCE_OPTIONSpattern, and because I want to keep this PR focused on the update. Adding a new submodule for this config would have some extra overhead.smithy-ts Change: smithy-lang/smithy-typescript#2145
Testing
unit/integ testing
Checklist
*.integ.spec.ts) or E2E tests.@public,@internaltags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.