Skip to content

Add missing proof model#159

Merged
denislavstanchev merged 3 commits into
mainlinefrom
add-proofs-model
Jul 16, 2026
Merged

Add missing proof model#159
denislavstanchev merged 3 commits into
mainlinefrom
add-proofs-model

Conversation

@denislavstanchev

Copy link
Copy Markdown
Contributor

Pull Request

Description

  • When using the get_report tool in MCP we noticed the proof field was not being populated. Added the missing proof model to the SDK and a proof field in the Row model

Related Issue

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Code refactoring
  • Other (please describe):

Environment Information

  • Smartsheet API Version: [e.g. 2.0]
  • Smartsheet Python SDK Version: [e.g. 3.0.0]
  • Python Version: [e.g. 3.10]

What Changes Were Made

Why These Changes Were Made

Testing

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have updated the relevant files in docs-source/ (see Documentation guidelines)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

@coveralls

coveralls commented Jul 15, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 29420360468

Warning

No base build found for commit 3433b49 on mainline.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 77.908%

Details

  • Patch coverage: 5 uncovered changes across 1 file (123 of 128 lines covered, 96.09%).

Uncovered Changes

File Changed Covered %
smartsheet/models/proof.py 110 105 95.45%
Total (5 files) 128 123 96.09%

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 10963
Covered Lines: 8541
Line Coverage: 77.91%
Coverage Strength: 3.9 hits per line

💛 - Coveralls

Comment thread smartsheet/models/proof.py Outdated
Comment thread smartsheet/models/row.py
@denislavstanchev
denislavstanchev merged commit 89b443d into mainline Jul 16, 2026
12 checks passed
@denislavstanchev
denislavstanchev deleted the add-proofs-model branch July 16, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants