fix: hit-die display desync + species natural armor AC#7
Merged
Conversation
Bug 1 — Hit die compute/display desync (adapers.py:51-58 vs :230): After archetype/class lookup overrides the hit die (e.g. primal_martial -> d12), the sheet displayed the original LLM value (d10). Fix: computed_values_to_sheet now resolves hit_die through the same HIT_DIE_BY_CLASS/HIT_DIE_BY_ARCHETYPE lookup tables. Bug 2 — Species natural armor not applied to AC (adapers.py:70-87): AC inputs were built exclusively from equipment; species traits like Carapace (natural armor AC 12) were ignored. Fix: - Added natural_armor_ac INPUT node to the DAG (dnd_5e_2024.py) - op_ac_with_armor now returns max(natural_armor_ac, armored_ac) - character_data_to_inputs parses species traits for natural armor AC (keyword match + regex AC value extraction) - assemble_character_inputs defaults natural_armor_ac to 0 11 new tests (4 hit-die display, 7 natural armor AC). 1646 total (was 1635). No regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
validate_power_budget(species_data, class_data, subclass_data, level) -> list[str]indndwright/rules/homebrew_validator.py.Problem
Today the only balance signal for homebrew characters is the LLM's self-graded
balance_score, never enforced. A "Superman (species-heavy) + Batman (class-heavy)" concept can stack a full species' traits AND a full class's features.Approach
Three checks against SRD baselines derived from dndwright's own content (not invented):
species.jsonclasses.jsonHigh-impact traits (flight, innate casting, resistance, breath weapon, darkvision/tremorsense) are weighted heavier.
Tests
17 new tests: balanced passes, species-over/fails, class-over/fails, combined-over (Superman+Batman)/fails, edge cases (empty data, missing traits, malformed lists, features below level).
1635 total (was 1618). No regressions.
Baseline derivation
Methodology documented in the source comments: counted traits per SRD species, cumulative features active at level per SRD class, set budgets slightly above SRD max to allow homebrew creativity while catching over-stacking.