docs: ScalaPB codegen CI + integration test completeness spec#95
Closed
ottobot-ai wants to merge 1 commit into
Closed
docs: ScalaPB codegen CI + integration test completeness spec#95ottobot-ai wants to merge 1 commit into
ottobot-ai wants to merge 1 commit into
Conversation
TDD-ready spec for the 3 remaining gaps in scalapb codegen: - CI never runs proto/test (only sharedData/test) - ScalaPBIntegrationTest covers 2/6 message types - Sequenced trait gap in ProtoAdapters undocumented Defines 4 new integration tests (T3-T6), exact CI workflow change, and proto/README.md documenting generation strategy and migration phase boundary. Trello: https://trello.com/c/IMFiVKvx
ottobot-ai
added a commit
to ottobot-ai/ottochain
that referenced
this pull request
Feb 24, 2026
- Add 4 missing integration tests (ArchiveStateMachine, CreateScript, InvokeScript, OttochainMessage union) to ScalaPBIntegrationTest.scala - Verify all 6 DataUpdate message types compile with mixin correctly - Fix CI: add proto/compile proto/test step before sharedData/test (proto module was previously invisible to CI) - Add modules/proto/README.md documenting build-time generation strategy, DataUpdate mixin integration, and ProtoAdapters Phase 1/2 boundary Spec: PR scasplte2#95 (docs/design/scalapb-codegen-spec.md) TDD gate: all tests compile = DataUpdate mixin works for all 6 types ~1.5h @work effort (simple, per spec) Closes Trello card: https://trello.com/c/IMFiVKvx (⚙️ ScalaPB: Configure codegen)
Collaborator
Author
|
Moving to feature branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spec for the remaining gaps in ScalaPB codegen configuration (card: ⚙️ ScalaPB: Configure codegen with DataUpdate mixins).
The core configuration (DataUpdate mixin, sbt-protoc, scalapb.gen) is already done on develop. This spec covers what's still missing.
What this spec defines
Task A — CI Fix: Add
sbt proto/compile proto/testas a dedicated step in.github/workflows/ci.yml(theprotomodule is currently never tested in CI)Task B — Integration Test Completeness: Add 4 missing tests to
ScalaPBIntegrationTest.scalacovering:ArchiveStateMachine extends DataUpdateCreateScript extends DataUpdateInvokeScript extends DataUpdateOttochainMessageunion type extendsDataUpdate(viaOttochainMessage.Message.CreateStateMachineoneof)Task C — Documentation:
modules/proto/README.mddocumenting:Spec document
docs/design/scalapb-codegen-spec.md— includes exact Scala test code with correct generated type constructors (verified against actual generated sources intarget/src_managed/).Dependencies
developdirectlyCloses Trello card: https://trello.com/c/IMFiVKvx
Reviewer: @scasplte2