test: scalaPB codegen integration tests + CI + proto README#96
Closed
ottobot-ai wants to merge 1 commit into
Closed
test: scalaPB codegen integration tests + CI + proto README#96ottobot-ai wants to merge 1 commit into
ottobot-ai wants to merge 1 commit into
Conversation
- Add 4 missing integration tests (ArchiveStateMachine, CreateScript, InvokeScript, OttochainMessage union) to ScalaPBIntegrationTest.scala - Verify all 6 DataUpdate message types compile with mixin correctly - Fix CI: add proto/compile proto/test step before sharedData/test (proto module was previously invisible to CI) - Add modules/proto/README.md documenting build-time generation strategy, DataUpdate mixin integration, and ProtoAdapters Phase 1/2 boundary Spec: PR scasplte2#95 (docs/design/scalapb-codegen-spec.md) TDD gate: all tests compile = DataUpdate mixin works for all 6 types ~1.5h @work effort (simple, per spec) Closes Trello card: https://trello.com/c/IMFiVKvx (⚙️ ScalaPB: Configure codegen)
ottobot-ai
changed the title
Collaborator
Author
|
Moving to feature branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the remaining gaps identified in ScalaPB codegen spec (PR #95).
Task A — CI Fix: Add
proto/compile proto/teststep to.github/workflows/ci.ymlprotomodule was previously invisible to CI (sharedData/testdoesn't trigger proto compilation)Task B — Integration Test Completeness: 4 new tests in
ScalaPBIntegrationTest.scala(was 2, now 6):ArchiveStateMachine extends DataUpdate✅CreateScript extends DataUpdate✅InvokeScript extends DataUpdate✅OttochainMessage union extends DataUpdate✅ (via oneof CreateStateMachine variant)All 6/6 DataUpdate message types now covered.
Task C — Documentation:
modules/proto/README.mdadded covering:Test Coverage
All 6 tests verify:
DataUpdatetype compiles (compile-time proof of mixin)isInstanceOf[DataUpdate]assertionDependencies
maindirectlyTrello
Closes: ⚙️ ScalaPB: Configure codegen with DataUpdate mixins
Reviewer: @scasplte2