fix(mu-core): tolerate the [dialogue] config section owned by mu-dialogue#486
Closed
tcovert-c137[bot] wants to merge 1 commit into
Closed
fix(mu-core): tolerate the [dialogue] config section owned by mu-dialogue#486tcovert-c137[bot] wants to merge 1 commit into
tcovert-c137[bot] wants to merge 1 commit into
Conversation
…ogue Live incident 2026-07-10: #482 introduced [dialogue.presence] into the shared ~/.config/mu/config.toml (read by mu-dialogue), but mu-core's Config has deny_unknown_fields — so mu-core consumers (mu ask, daemon, orchestrate) rejected the ENTIRE file and silently fell back to built-in defaults (no mcp servers, no providers). Config gains an opaque, uninterpreted 'dialogue: Option<toml::Value>' passthrough: the co-resident section parses, everything else still populates, and deny_unknown_fields keeps rejecting real typos (regression test covers all three properties). Found by cc:9465d7f3 (blocked mu-vneb: config-defined providers never loaded while the config was rejected).
Contributor
Author
|
Duplicate of #485 — we raced on the same incident and shipped the identical design (opaque |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hotfix for a live incident my #482 caused:
[dialogue.presence]landed in the shared~/.config/mu/config.toml(owned/read by mu-dialogue), but mu-core'sConfigusesdeny_unknown_fields— so every mu-core consumer (mu ask, daemon, orchestrate) rejected the entire file and silently ran on built-in defaults (no MCP servers, no providers). Found by another cc session when config-defined providers stopped loading (blocked mu-vneb).Fix:
Configgains an opaquedialogue: Option<toml::Value>passthrough — the co-resident section is tolerated without being interpreted, everything else still populates, anddeny_unknown_fieldscontinues to hard-error on genuine typos. Regression test asserts all three properties (dialogue_section_is_tolerated_not_fatal).Testing
just cigreen in a sprint workspace based on main (c99240b2, which reproduced the failure).mu versionsagainst the real shared config (containing[dialogue.presence]) — noCONFIG ERRORon stderr.Small + blocking concurrent work — review when convenient.
🤖 Generated with Claude Code
https://claude.ai/code/session_019YY9xpjK6mWLJDMaYnvC6T