fix(mu-core): tolerate the [dialogue] config section owned by mu-dialogue#485
Merged
Conversation
…ogue The operator ~/.config/mu/config.toml is SHARED between mu-core (mu ask / daemon / orchestrate, via Config::load_default) and the mu-dialogue binary. mu#482 added a [dialogue.presence] section for mu-dialogue, but mu-core's Config uses deny_unknown_fields and has no dialogue field — so mu-core rejected the ENTIRE config and silently fell back to built-in defaults (no MCP servers, no providers, no session settings). Confirmed live on c99240b. Accept-and-ignore [dialogue] as an opaque passthrough (Option<toml::Value>) so mu-core tolerates the section it does not own. Regression test added.
Contributor
Author
|
Closing as a duplicate of #486 — the sibling cc session shipped the same fix (identical approach: opaque |
sahuagin
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live config-break introduced by #482. The operator
~/.config/mu/config.tomlis shared between mu-core (mu ask/daemon/orchestrate viaConfig::load_default) and the mu-dialogue binary. #482 added a[dialogue.presence]section for mu-dialogue, but mu-core'sConfigusesdeny_unknown_fieldsand has nodialoguefield — so mu-core rejects the entire config and silently falls back to built-in defaults (no MCP servers, no config-defined providers, no session settings). Confirmed live onc99240b2by building + runningmu ask→CONFIG ERROR … unknown field dialogue … entire config ignored.Fix: accept-and-ignore
[dialogue]as an opaqueOption<toml::Value>passthrough so mu-core tolerates the section it doesn't own. Regression test added;mu-coretests + clippy clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01RC1Lv7PR4KdNxM64EhCoYF