Drop PHP 7#767
Conversation
I have no idea how the tests found |
|
Finds nothing. So there never has been any file in this repo with "foo" in its name. And I don't see any code that will create Edit add: The test cases actually expected the Cli to exit with status "2". So they did expect that a problem would be reported - the input file does not exist. Due to changes in PHPunit11, the test code was now exposed to the PHP warning from fopen. So I needed to handle that in the test code, and make a small addition to the real code to throw an InvalidDataException when |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #767 +/- ##
============================================
- Coverage 98.69% 98.66% -0.04%
+ Complexity 1891 1757 -134
============================================
Files 71 71
Lines 5300 5163 -137
============================================
- Hits 5231 5094 -137
Misses 69 69 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
81982c8 to
29260f7
Compare
And adjust the related unit test testConvertDefaultFormats so that it handles the PHP warning that is emitted by fopen. The Cli code catches InvalidDataException and exits with status 2, which is what was always expected by the unit test code. So this should preserve the real behavior. The test changes are necessary because PHPunit11 now exposes the PHP warning coming from fopen. So we catch and expect that in an error handler in the test.
29260f7 to
5a4792f
Compare
6b07557 to
9f6cd1c
Compare
|
Will this lead to a new major release? (does dropping old PHP versions trigger SemVer?) |
Normally I would just make a minor release for dropping PHP versions. So I will make this a major version. That gives consumers the option to specifically choose to update. |
2d35ee7 to
0d7d134
Compare
Uh oh!
There was an error while loading. Please reload this page.