Skip to content

chore: support PHP 8.2 and up#766

Closed
phil-davis wants to merge 3 commits into
sabre-io:masterfrom
phil-davis:support-php8.2-and-up
Closed

chore: support PHP 8.2 and up#766
phil-davis wants to merge 3 commits into
sabre-io:masterfrom
phil-davis:support-php8.2-and-up

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

WIP - phpstan has a lot to say.

Drops support for PHP 7.4 8.0 8.1
Adds rector.

@phil-davis

Copy link
Copy Markdown
Contributor Author

Hmmm - I made lots of little changes to make phpstan happy.
cs-fixer, rector and phpstan all pass:
https://github.com/sabre-io/vobject/actions/runs/27263542513/job/80514925678?pr=766

But I have badly broken the unit tests! Now to look through what I did and spot what I broke.

@phil-davis

Copy link
Copy Markdown
Contributor Author

See PR #767
I did that in smaller pieces, running phpunit locally a lot to make sure that I hadn't broken the tests.

@phil-davis phil-davis closed this Jun 14, 2026
@phil-davis phil-davis deleted the support-php8.2-and-up branch June 14, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant