Add Model::try_set_option method#40
Merged
Merged
Conversation
There are potential uses for it outside the crate, so let's re-export it. Closes rust-or#39.
Contributor
Author
|
Oops, looks like clippy's complaining. I'll fix that up. |
…g option fails Closes rust-or#38.
alexdewar
force-pushed
the
try-set-option
branch
from
ce8e4e3 to
5bd69ab
Compare
Contributor
Author
|
Right, should be all good for review now. |
Contributor
Author
|
Nw, thanks for looking at this 😄. Were you planning on making a new release soon btw? I'd like to use this feature in my downstream project. I can always use the git version of this crate for now if not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #38, the
Model::set_optionmethod panics in the case of error, such as if an option does not exist or the value is invalid. While this is fine when you know you will only be setting valid options, it is not good if you are setting options dynamically, such as via user input. You can catch panics in Rust, but it's rather painful and it would be easier all round if we could just return an error in the usual way in this case.Add a separate
Model::try_set_optionmethod which returns an error if it fails.While I was at it, I tidied up another error message and changed things so that
HighsOptionValueis re-exported as suggested in #39 (I was fiddling with this part of the code anyway).Closes #38. Closes #39.