Fix: Model::try_set_option: Return error if option name contains NUL char#41
Merged
lovasoa merged 1 commit intoMay 2, 2026
Merged
Conversation
…L char Currently it panics in the case that there is a NUL char in the option name, but there's no reason really to treat these bad option names as different from any other. Return an error in this case too.
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a small follow-on to #40.
Currently
Model::try_set_optionpanics in the case that there is a NUL char in the option name, but there's no reason really to treat these bad option names as different from any other. Return an error in this case too.It's probably unlikely that a user would do this, but we don't document that this function can panic, so let's make it safer by returning an error.