Clarify RFC merge instructions#1056
Open
carols10cents wants to merge 1 commit into
Open
Conversation
If you can't push directly to the repo, the commits moving the RFC file and adding links can be pushed to the RFC's branch and merged with the RFC PR, not in a new PR.
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @scottmcm rustbot has assigned @scottmcm. Use Why was this reviewer chosen?The reviewer was selected based on:
|
ehuss
reviewed
May 28, 2026
| ### Step 2: Merge the RFC PR itself | ||
|
|
||
| In your local git checkout: | ||
| If you have permissions to push directly to rust-lang/rfcs, then in your local git checkout: |
Contributor
There was a problem hiding this comment.
Everyone in the org has the same write permissions on rust-lang/rfcs. Can you say why it seemed like you didn't have the ability to push?
Generally there shouldn't ever be a need to open a new PR.
Member
There was a problem hiding this comment.
(Specifically, all = "write" https://github.com/rust-lang/team/blob/a19f3ba475b8248eaea4e7b5b3fa67abe7cdcb3d/repos/rust-lang/rfcs.toml#L7-L8)
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
I don't merge RFCs very often, so I went looking for instructions on how to merge them. I happened across this page and started following the instructions-- then found I don't actually have permission to push directly to rust-lang/rfcs master 😅
The instructions said "Open a PR" so I did, even though that felt strange rather than just pushing them to my RFC's PR, and then I was informed that what I did was indeed strange.
Fix
So I rearranged these instructions to first split based on permissions, then direct those without permissions to add to their existing PR rather than making a new one (assuming the person merging is the PR author, which I believe to be the usual case).
Rendered