Revert "update fate-locked-ironman"#13079
Merged
Merged
Conversation
This reverts commit 79ccb04.
|
Includes changes by non-author
|
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 79ccb04.
@Nubles since you're adding it after the initial release of the plugin, all your networking calls to your custom domain MUST be opt-in through an explicit boolean config, with its
@ConfigItem::warningfield set to "This feature submits your IP address to a 3rd-party server not controlled or verified by Runelite developers". Methods that make API calls to this domain should have a clear check for this config at the top, which either returns early or throws an exception if false, so we can exhaustively verify that you're not making these calls without user consent.