Update fate-locked-ironman: re-add online sync (opt-in, consent-gated)#13085
Merged
Conversation
|
|
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-submitting online sync after the #13079 revert, now gated hopefully as required
New boolean config onlineSync (default false) with @ConfigItem.warning = "This feature submits your IP address to a 3rd-party server not controlled or verified by Runelite developers" enabling it triggers RuneLite's confirmation dialog.
pollRelay() is the only method that contacts the relay domain, and it returns early on its first line when onlineSync() is false, so no request is made without consent.
Outbound-only, injected OkHttpClient, ephemeral 24h relay keyed by a random pairing code; no account credentials in the payload.
Please let me know if there is anything else that needs sorting, apologies for not doing it correctly.