Add dynamicfeed_ros (humble, jazzy)#52004
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Thanks for sending a pull request to ROS distro!
This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.
ROS Distro Considerations
- ROS Distributions are created using REP-134 Standards Track as a guide.
- Your package name should comply to REP-144 ROS Package Naming
- Your package must build for all platforms and architectures on the ROS buildfarm. See REP-2000 ROS Releases and Supported Platforms for all supported platforms for your ROS Distro.
- Your package must contain an OSI approved license. Your
package.xmlfile must also include that license in a machine readable format. See REP-149 Package Manifest Format Three Specification for additional details. - A publicly available, open source, repository for your ROS package.
- While not required, we recommend that you create an account for ROS Discourse and subscribe to the appropriate release topic.
- If you would like, you may join our Zulip Server and ask questions in the
Infrastructure Generalchannel.
Package Considerations
Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.
- REP-2004 Package Quality Declaration-- The ROS 2 TSC has created a quality rating system for ROS packages. These ratings should serve as a guide for package developers. We recommend package developers achieve a quality level of three or higher.
- Documentation -- it is recommended that ROS packages include an extensive README.md file, and API level documentation using the Sphinx documentation system.
- Maintainer Responsibilities -- the ROS 2 documentation includes a guide to ROS package maintainer responsibilities that summarizes your responsibilities as an open source maintainer. While we do not enforce these requirements on package maintainers they should be considered best practices.
- We recommend that your package should strive to conform to the ROS 2 Developer Guide and the ROS 2 Style Guide.
Need Help?
Please post your questions to Robotics Stack Exchange or refer to the Infrastructure General channel on our Zulip server.
For changes related to rosdistro:
- ✅ New repositories are named appropriately
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
Yadunund
left a comment
There was a problem hiding this comment.
@Liquid00000000000 thanks for the PR. Would you like to index your packages for rolling too? The advantage there is that they will automatically be available in future ROS releases as these branch off Rolling. You may also like to consider adding doc tags if you would like documentation to be autogenerated for these packages.
- At least one of the following must be present
- Top level license file: https://github.com/dynamicfeed/dynamicfeed-ros/blob/main/LICENSE
- Per package license files:
- License is OSI-approved: Yes, MIT
- License correctly listed in package.xmls: https://github.com/dynamicfeed/dynamicfeed-ros/blob/c1096347488008ee3b7ea26d71b570f8ff7762a0/dynamicfeed_awareness/package.xml#L8
- Public source repo: https://github.com/dynamicfeed/dynamicfeed-ros
- Source repository contains ROS packages: Yes
- Each package meets REP-144 naming conventions
Tagging @asymingt for secondary approval.
asymingt
left a comment
There was a problem hiding this comment.
Can we use an underscore rather than a hyphen in the package key? https://ros.org/reps/rep-0144.html
| url: https://github.com/pradyum/dual_laser_merger.git | ||
| version: humble | ||
| status: developed | ||
| dynamicfeed-ros: |
There was a problem hiding this comment.
I know this isn't strictly a package name (although I do think you should have a dynamicfeed_ros metapackage with <depends></depends> on your three packages) but I do think it should use an underscore rather than a hyphen. Are there any other keys in this YAML file that use a hyphen?
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Requested in ros/rosdistro#52004 review: a metapackage matching the rosdistro repository key, with exec_depends on the three packages. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Done — renamed the repository key to Also added a On your question: yes, a few existing keys do use hyphens — 9 in Thanks for the review. |
|
Thank you for the submission!
Package name details$ find . -name "package.xml" -exec grep --color=auto -e "<name>" "{}" ";"
<name>dynamicfeed_msgs</name>
<name>dynamicfeed_awareness</name>
<name>dynamicfeed_bringup</name>License details$ find . -name "package.xml" -exec grep --color=auto -e "<license>" "{}" "+"
<license>MIT</license>
<license>MIT</license>
<license>MIT</license> |
|
@Dynamicfeedai friendly ping on other review feedback here. |
Adds a source entry for dynamicfeed-ros to the
humbleandjazzydistributions.dynamicfeed-ros publishes live, Ed25519-signature-verified world-data topics for ROS 2 (weather, natural hazards, GPS interference, air quality, space weather) from the keyless Dynamic Feed API, with the signature verified on the robot.
Packages in the repository (all
package.xmlformat 3, version 0.1.0, maintainer and license set):dynamicfeed_msgs— message interfaces (Provenance trust envelope, HazardAlert, GpsInterference, AirQuality, SpaceWeather)dynamicfeed_awareness—ament_pythonnode publishing the signed data as standard ROS topicsdynamicfeed_bringup— launch files and configurationChecklist:
LICENSEfile (MIT, OSI-approved); license reflected in everypackage.xmlpackage.xml, format 3)versionis a branch (main); no tag of the same name existsDocumentation: https://dynamicfeed.ai/standard
🤖 Generated with Claude Code