Skip to content

Add dynamicfeed_ros (humble, jazzy)#52004

Open
Dynamicfeedai wants to merge 2 commits into
ros:masterfrom
dynamicfeed:add-dynamicfeed-ros
Open

Add dynamicfeed_ros (humble, jazzy)#52004
Dynamicfeedai wants to merge 2 commits into
ros:masterfrom
dynamicfeed:add-dynamicfeed-ros

Conversation

@Dynamicfeedai

Copy link
Copy Markdown

Adds a source entry for dynamicfeed-ros to the humble and jazzy distributions.

dynamicfeed-ros publishes live, Ed25519-signature-verified world-data topics for ROS 2 (weather, natural hazards, GPS interference, air quality, space weather) from the keyless Dynamic Feed API, with the signature verified on the robot.

Packages in the repository (all package.xml format 3, version 0.1.0, maintainer and license set):

  • dynamicfeed_msgs — message interfaces (Provenance trust envelope, HazardAlert, GpsInterference, AirQuality, SpaceWeather)
  • dynamicfeed_awarenessament_python node publishing the signed data as standard ROS topics
  • dynamicfeed_bringup — launch files and configuration

Checklist:

  • Top-level LICENSE file (MIT, OSI-approved); license reflected in every package.xml
  • Public source repository: https://github.com/dynamicfeed/dynamicfeed-ros
  • Repository contains ROS packages (3 package.xml, format 3)
  • Package names comply with REP-144
  • version is a branch (main); no tag of the same name exists
  • CI green on Humble and Jazzy (colcon build) at the indexed branch
  • Not a fork of an existing ROS package; brand-new to the ecosystem

Documentation: https://dynamicfeed.ai/standard

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions github-actions Bot added humble Issue/PR is for the ROS 2 Humble distribution jazzy Issue/PR is for the ROS 2 Jazzy distribution labels Jun 10, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the Infrastructure General channel on our Zulip server.


For changes related to rosdistro:

  • ✅ New repositories are named appropriately

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@Yadunund Yadunund left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Liquid00000000000 thanks for the PR. Would you like to index your packages for rolling too? The advantage there is that they will automatically be available in future ROS releases as these branch off Rolling. You may also like to consider adding doc tags if you would like documentation to be autogenerated for these packages.

Tagging @asymingt for secondary approval.

@asymingt asymingt self-requested a review June 12, 2026 20:08

@asymingt asymingt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use an underscore rather than a hyphen in the package key? https://ros.org/reps/rep-0144.html

Comment thread humble/distribution.yaml Outdated
url: https://github.com/pradyum/dual_laser_merger.git
version: humble
status: developed
dynamicfeed-ros:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't strictly a package name (although I do think you should have a dynamicfeed_ros metapackage with <depends></depends> on your three packages) but I do think it should use an underscore rather than a hyphen. Are there any other keys in this YAML file that use a hyphen?

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdistro:

  • ✅ New repositories are named appropriately

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Dynamicfeedai pushed a commit to dynamicfeed/dynamicfeed-ros that referenced this pull request Jun 12, 2026
Requested in ros/rosdistro#52004 review: a metapackage matching the
rosdistro repository key, with exec_depends on the three packages.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Dynamicfeedai

Copy link
Copy Markdown
Author

Done — renamed the repository key to dynamicfeed_ros in both humble/distribution.yaml and jazzy/distribution.yaml, and re-checked the alphabetical ordering (it sorts into the same position, between dual_laser_merger and dynamixel_hardware).

Also added a dynamicfeed_ros metapackage on main (the branch this entry tracks) with exec_depends on the three packages (dynamicfeed_msgs, dynamicfeed_awareness, dynamicfeed_bringup): dynamicfeed/dynamicfeed-ros@fe27199.

On your question: yes, a few existing keys do use hyphens — 9 in humble/distribution.yaml (e.g. depthai-ros, ouster-ros, foxglove-sdk) and 7 in jazzy/distribution.yaml — but happy to follow the underscore convention for new entries.

Thanks for the review.

@mjcarroll

Copy link
Copy Markdown
Member

Thank you for the submission!

  • At least one of the following must be present
    • Top level license file: LICENSE (MIT)
    • Per package license files:
  • License is OSI-approved: MIT ✅
  • License correctly listed in package.xmls: MIT in all packages ✅
  • Public source repo: https://github.com/dynamicfeed/dynamicfeed-ros
  • Source repository contains ROS packages ✅
  • Not a fork ✅
  • Each package meets REP-144 naming conventions ✅
Package name details
$ find . -name "package.xml" -exec grep --color=auto -e "<name>" "{}" ";"
<name>dynamicfeed_msgs</name>
<name>dynamicfeed_awareness</name>
<name>dynamicfeed_bringup</name>
License details
$ find . -name "package.xml" -exec grep --color=auto -e "<license>" "{}" "+"
<license>MIT</license>
<license>MIT</license>
<license>MIT</license>

@mjcarroll

Copy link
Copy Markdown
Member

@Dynamicfeedai friendly ping on other review feedback here.

@christophebedard christophebedard added changes requested Maintainers have asked for changes to the pull request held for sync Issue/PR has been held because the distribution is in a sync hold labels Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested Maintainers have asked for changes to the pull request held for sync Issue/PR has been held because the distribution is in a sync hold humble Issue/PR is for the ROS 2 Humble distribution jazzy Issue/PR is for the ROS 2 Jazzy distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants