Skip to content

Do not save rocksdict config when open in read-only modes #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Congyuwang merged 1 commit into from
Jan 16, 2026
Merged

Do not save rocksdict config when open in read-only modes #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/rdict.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,15 @@ impl Rdict {
raw_mode: options.raw_mode,
prefix_extractors: prefix_extractors.clone(),
};
rocksdict_config.save(config_path)?;
// if access type is read only, do not save rocksdict config
match &access_type.0 {
AccessTypeInner::ReadWrite | AccessTypeInner::WithTTL { .. } => {
rocksdict_config.save(config_path)?;
}
_ => {
// Skip saving config for ReadOnly and Secondary modes
}
}
let opt_inner = &options.inner_opt;
// define column families
let cfs = match column_families {
Expand Down
Loading