Do not save rocksdict config when open in read-only modes#186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation of RocksDict, when opening a Rdict, it will save the RocksDict config file to the directory. However, if that directory is read-only, writing the config file will fail.
Currently the config file is saved to allow further construction of Rdict without need to specify the same config, so skip saving the config file will not affect the main functionality.
So in this PR, we propose to skip saving config if we open Rdict in read-only modes (
ReadOnlyandSecondary). This allows us to open a dictionary in a read-only directory.