ci: gate the strict docs build in ci-ok via the quality job#49
Merged
Conversation
docs.yml's build job lives in a different workflow, so it can't join ci-ok's needs list and a broken strict docs build could merge green. Mirrors the same fix in kitchenbench. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same gap the kitchenbench docs-site review flagged (robocurve/kitchenbench#21):
docs.yml's build job is in a different workflow, so it can't be added toci-ok's needs list, meaning a PR that breaksmkdocs build --strict(a dead internal link, say) merges green and only fails later on main with no alert. Running the strict build inside the quality job puts it behind the required check.Verified locally:
uv sync --locked --extra dev --extra docs+uv run mkdocs build --strictpasses.🤖 Generated with Claude Code