feat: add seconds-based task horizons#161
Open
Vedangalle wants to merge 1 commit into
Open
Conversation
Vedangalle
marked this pull request as ready for review
July 22, 2026 07:55
Contributor
|
please close this maintainer assigned this issue to me |
Contributor
|
check this robocurve/kitchenbench#29 |
Author
|
Thanks for flagging this, and sorry - I missed Jay’s note on KitchenBench #29 that #160 was yours first. I saw the framework issue unassigned and implemented it from there; I don’t want to duplicate or cut across your work. Since #161 now contains the core framework implementation and validation, could we coordinate by keeping this PR for the |
Contributor
|
please close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add seconds-based task horizons as an alternative to fixed step counts. This lets benchmark authors express a physical duration without coupling the task definition to one embodiment's control rate, while preserving the integer
TaskEnvelope.max_stepscontract used by adapters.Changes
Taskto declare exactly one ofmax_stepsor keyword-onlymax_seconds.control_hzvalues as positive and finite.ceil(max_seconds * control_hz)after compatibility checking and beforebind_task()or rollout, with a one-step minimum for positive floating-point underflow.max_secondsand resolvedmax_stepsin EvalLog schema v1 while preserving old-log compatibility.inspect,eval-set, and HTML reports.Rate-unknown and event-driven embodiments continue to use
max_steps. Scorer interfaces, ad-hoc--max-steps, rollout pacing, and dependencies are unchanged.Checklist
pre-commit run --all-filesand the pre-push hook stage pass.769 passed, 2 skipped).ruff check .andruff format --check .pass.mypypasses.CHANGELOG.mdupdated under "Unreleased".Additional documentation checks:
Related
Closes #160