Skip to content

Allow audit URLs to be used instead of diffs #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adam-ja wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allow audit URLs to be used instead of diffs #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e907b21
Fix release cut off check
Feb 2, 2017
49a01ed
Merge remote-tracking branch 'upstream/master'
Nov 14, 2017
7b3b91b
Allow audit URLs to be used instead of diffs
Nov 14, 2017
19a238c
Improve terminology from Audit to Commit
Nov 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions public/stylesheets/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,15 @@ body { padding-top: 50px; }
}

/** angular-ui */
.nav, .pagination, .carousel, .panel-title a {
cursor: pointer;
.nav, .pagination, .carousel, .panel-title a {
cursor: pointer;
}

.diff-row {
margin-bottom: 15px;
}

.diff-link {
overflow: hidden;
text-overflow: ellipsis;
}
4 changes: 2 additions & 2 deletions views/partials/release-ticket-diff-add.jade
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ div(class='modal-body')
ng-submit='submit(addDiff.$valid)'
)
div(class='form-group')
label(class='control-label col-sm-2') Phabricator Diff
label(class='control-label col-sm-2') Phabricator Diff/Commit
div(class='col-sm-10')
input(
type='text',
class='form-control',
placeholder='D####',
placeholder='D#### or r[REPO][commit hash]',
required,
ng-model='newDiff.diffId'
)
Expand Down
2 changes: 1 addition & 1 deletion views/partials/release-view.jade
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ div(ng-show="release")
ng-show='diff.repoName',
title='Added {{ diff.created | date:"EEEE, MMMM d yyyy HH:mm:ss" }}'
) {{diff.repoName}}
div(class='col-sm-2', ng-class='{"text-muted": diff.released}')
div(class='col-sm-2 diff-link', ng-class='{"text-muted": diff.released}')
a(href='http://phab.dev.ebuyer.com/{{diff.diffId}}') {{diff.diffId}}
div(class='col-sm-2', ng-class='{"text-success": diff.released && !diff.rolledBack}')
span(ng-show='diff.released && !diff.rolledBack')
Expand Down