Allow audit URLs to be used instead of diffs - #13
Open
adam-ja wants to merge 4 commits into
Open
Conversation
added 3 commits
February 2, 2017 15:38
Previously the cut off warning would always appear if the current hour was 14 or higher. This meant that a release two or more days into the future could show the warning prematurely (e.g. we should be able to add tickets to a release on Wednesday after 2pm on Monday but the warning was still showing). Now, the cut off warning actually takes into account the date of the release and only shows the warning after 2pm on the last working day before the release.
Sometimes, we need to release quick fixes that were not reviewed. We still want to add these to the release app for visibility and, rather than linking to nothing, we can link to the audit on phab. For example, link to http://phab.dev.ebuyer.com/rGENONEfcc395703a1f8edee04db518ed56c121705900fe rather than http://phab.dev.ebuyer.com/D5610 This patch updates the Add Diff form to indicate this possibility, and improves the styling of the release view so that lengthy commit hashes do not overflow other elements of a release (such as the Release button/Released status text).
Author
|
BEFORE: AFTER: |
tkjn
reviewed
Nov 14, 2017
| ) | ||
| div(class='form-group') | ||
| label(class='control-label col-sm-2') Phabricator Diff | ||
| label(class='control-label col-sm-2') Phabricator Diff/Audit |
Collaborator
There was a problem hiding this comment.
I don't think it's necessarily a link to an "Audit". It's a link to a "Commit", sometimes those commits require Audit.
(shrug)
There was a problem hiding this comment.
That is indeed the case and, depending on which repo is being committed to, the audit may not be created immediately. "Commit" would be more appropriate terminology.
We can link to any commit on phabricator, regardless of whether or not that commit requires auditing.
tkjn
approved these changes
Nov 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, we need to release quick fixes that were not reviewed. We still want to add these to the release app for visibility and, rather than linking to nothing, we can link to the audit on phab.
For example, link to http://phab.dev.ebuyer.com/rGENONEfcc395703a1f8edee04db518ed56c121705900fe rather than http://phab.dev.ebuyer.com/D5610
This patch updates the Add Diff form to indicate this possibility, and improves the styling of the release view so that lengthy commit hashes do not overflow other elements of a release (such as the Release button/Released status text).