Update Declare Recipes packet and add packet for unlock recipes#589
Closed
BL19 wants to merge 1 commit into
Closed
Update Declare Recipes packet and add packet for unlock recipes#589BL19 wants to merge 1 commit into
BL19 wants to merge 1 commit into
Conversation
Owner
|
Thank you for this PR. Will look into using this PR to complete the recipe wrappers and also update them to 1.20. |
NoJokeFNA
suggested changes
Feb 7, 2024
| private final int width; | ||
| private final int height; | ||
| private final @NotNull String group; | ||
| private CraftingBookCategory category; |
Contributor
There was a problem hiding this comment.
Suggested change
| private CraftingBookCategory category; | |
| private final CraftingBookCategory category; |
| private final @NotNull String group; | ||
| private final @NotNull Ingredient[] ingredients; | ||
| private final ItemStack result; | ||
| private CraftingBookCategory category; |
Contributor
There was a problem hiding this comment.
Suggested change
| private CraftingBookCategory category; | |
| private final CraftingBookCategory category; |
| return result; | ||
| } | ||
|
|
||
| public CraftingBookCategory getCategory() { |
Contributor
There was a problem hiding this comment.
Is the @Nullable annotation not needed?
| private final ItemStack result; | ||
|
|
||
| public ShapedRecipeData(final int width, final int height, final @NotNull String group, final @NotNull Ingredient[] ingredients, final ItemStack result) { | ||
| public ShapedRecipeData(final int width, final int height, final @NotNull String group, final @NotNull CraftingBookCategory category, final @NotNull Ingredient[] ingredients, final ItemStack result) { |
Contributor
There was a problem hiding this comment.
Is the CraftingBookCategory version-specific? If yes, please make a second constructor
| super(packetType); | ||
| } | ||
|
|
||
| RecipeBookAction action; |
Contributor
There was a problem hiding this comment.
Please add private final everywhere
| import com.github.retrooper.packetevents.wrapper.PacketWrapper; | ||
|
|
||
| public class WrapperPlayServerUnlockRecipes extends PacketWrapper<WrapperPlayServerUnlockRecipes> { | ||
|
|
| recipeIds[i] = readString(); | ||
| } | ||
|
|
||
| if(action == RecipeBookAction.INIT) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if(action == RecipeBookAction.INIT) { | |
| if (action == RecipeBookAction.INIT) { | |
| writeString(recipeId); | ||
| } | ||
|
|
||
| if(action == RecipeBookAction.INIT) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if(action == RecipeBookAction.INIT) { | |
| if (action == RecipeBookAction.INIT) { |
Contributor
|
Hold up, I just saw the "WrapperPlayServerUnlockRecipes" class. It's definetly not cross-version and a duplicate of #382 |
Author
|
Closing since I don't really have time to fix this and have no use for it anymore. Might open a new PR if I need this again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It adds the packet for unlocking recipes and updates the packet for declaring recipes to contain the CraftingBookCategory.
Tested on: 1.19.3 & 1.19.4