Fix recipe packet writing/reading#799
Merged
Merged
Conversation
Collaborator
|
Please resolve the conflict with the new build configuration. |
Collaborator
Author
Done |
booky10
force-pushed
the
fix/recipe-packet
branch
from
0890002 to
3974da2
Compare
booky10
force-pushed
the
fix/recipe-packet
branch
from
3974da2 to
48fbb74
Compare
retrooper
requested changes
Jun 27, 2024
retrooper
left a comment
retrooper
left a comment
Owner
There was a problem hiding this comment.
Some comments crediting MCProtocol could be removed since we rewrote the classes.
retrooper
approved these changes
Jun 27, 2024
Owner
|
Thanks for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for 1.19.3+ to the recipe packet:
Supersedes some parts of #589, but doesn't include an unlock recipe packet wrapper