Skip to content

RDKB-65989: Move MAP-T ratio calculation to WanManager from DHCPManager #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sivaraj-comcast wants to merge 15 commits into
base: main
Choose a base branch
from
Open

RDKB-65989: Move MAP-T ratio calculation to WanManager from DHCPManager #225

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
bbe3d59
RDKB-64484: Allow psid offset value 0 for MAPT config
sivaraj-comcast Apr 15, 2026
7e54d14
Apply suggestion from @Copilot
sivaraj-comcast Apr 15, 2026
ddf62f1
Apply suggestion from @Copilot
sivaraj-comcast Apr 15, 2026
7201959
RDKB-64484: Allow psid offset value 0 for MAPT config
sivaraj-comcast Apr 15, 2026
5b703a6
Apply suggestion from @Copilot
sivaraj-comcast Apr 15, 2026
e2c2819
Apply suggestion from @Copilot
sivaraj-comcast Apr 15, 2026
aa34186
Update dhcpv6c_msg_apis.c
sivaraj-comcast Apr 16, 2026
1dd3eaf
Update dhcpv6c_msg_apis.c
sivaraj-comcast Apr 16, 2026
6c60ec5
Apply suggestion from @Copilot
sivaraj-comcast Apr 17, 2026
13050d8
Apply suggestion from @Copilot
sivaraj-comcast Apr 17, 2026
c0b1808
review comments incorporated
sivaraj-comcast Apr 17, 2026
2b75944
Update dhcpv6c_msg_apis.c
sivaraj-comcast Apr 17, 2026
289f380
Merge branch 'rdkcentral:main' into main
sivaraj-comcast Apr 27, 2026
be2cd41
Merge branch 'rdkcentral:main' into main
sivaraj-comcast Aug 4, 2026
9e7b18d
RDKB-65989: Move MAP-T ratio calculation to WanManager from DHCPManager
sivaraj-comcast Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions source/WanManager/wanmgr_net_utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,10 +852,6 @@ ANSC_STATUS WanManager_VerifyMAPTConfiguration(ipc_map_data_t *dhcp6cMAPTMsgBody
return ANSC_STATUS_FAILURE;
}

//The sharing ratio cannot be zero, a value of zero means the sharing ratio is 1
if (dhcp6cMAPTMsgBody->ratio == 0)
dhcp6cMAPTMsgBody->ratio = 1;

#ifdef FEATURE_MAPT_DEBUG
WanManager_UpdateMaptLogFile(dhcp6cMAPTMsgBody);
#endif
Expand Down Expand Up @@ -895,6 +891,9 @@ ANSC_STATUS WanManager_VerifyMAPTConfiguration(ipc_map_data_t *dhcp6cMAPTMsgBody
MaptConfig->isPSIDComputed = TRUE;
}

/* Ownership moved from DHCPManager: Compute ratio after psidLen is resolved */
dhcp6cMAPTMsgBody->ratio = (MaptConfig->psidLen > 0) ? (1 << MaptConfig->psidLen) : 1;
Comment thread
sivaraj-comcast marked this conversation as resolved.

inet_pton(AF_INET, dhcp6cMAPTMsgBody->ruleIPv4Prefix, &(result));

ipValue = htonl(result.s_addr) + ipv4IndexValue;
Expand Down