RDKB-65989: Move MAP-T ratio calculation to WanManager from DHCPManager - #225
Open
sivaraj-comcast wants to merge 15 commits into
Open
RDKB-65989: Move MAP-T ratio calculation to WanManager from DHCPManager#225sivaraj-comcast wants to merge 15 commits into
sivaraj-comcast wants to merge 15 commits into
Conversation
RDKB-64484: Allow psid offset value 0 for MAPT configuration Reason for change: Remove setting defalut value for PSID Offset to allow using psid offset 0 from the backend Test Procedure: Verify the psid offset 0 is configured for MAPT when CE receives it from DHCPV6 Option95 (suboption 93) response Risks: Low Priority:P1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
RDKB-64484: Allow psid offset value 0 for MAPT configuration Reason for change: Remove setting defalut value for PSID Offset to allow using psid offset 0 from the backend Test Procedure: Verify the psid offset 0 is configured for MAPT when CE receives it from DHCPV6 Option95 (suboption 93) response Risks: Low Priority:P1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Added psid len validation. Updated log type / log message
Reason for change: DHCPManager now sends ratio=0 in the rbus event, since ratio computation is removed from DHCPManager; WanManager derives ratio from psidLen as the single authoritative owner. Test Procedure: Verify "sysevent get mapt_ratio" and Device.MAP.Domain.1.Rule.1.X_RDKCENTRAL-COM_Ratio / Device.DHCPv6.Client.1.X_RDKCENTRAL-COM_RcvOption.MapRatio is correctly set by WanManager after MAPT is configured. Risks: Low Priority: P1 Signed-off-by: Sivaraj_Sivalingam@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
Moves MAP-T sharing ratio computation out of DHCPManager and into WanManager so WanManager becomes the single authoritative owner of ratio, deriving it from the resolved psidLen (including the computed-PSID path).
Changes:
- Removes the legacy “ratio==0 means 1” normalization in
WanManager_VerifyMAPTConfiguration. - Computes
dhcp6cMAPTMsgBody->ratioin WanManager afterpsidLenis determined (from DHCPv6 option or computed PSID path).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: DHCPManager now sends ratio=0 in the rbus event, since ratio computation is removed from DHCPManager; WanManager derives ratio from psidLen as the single authoritative owner.
Test Procedure: Verify "sysevent get mapt_ratio" and Device.MAP.Domain.1.Rule.1.X_RDKCENTRAL-COM_Ratio / Device.DHCPv6.Client.1.X_RDKCENTRAL-COM_RcvOption.MapRatio is correctly set by WanManager after MAPT is configured.
Risks: Low
Priority: P1
Signed-off-by: Sivaraj_Sivalingam@comcast.com