Fix always-true response.c_str() guards in Device_WiFi_SSID RPC response handling - #402
Open
Vismalskumar0 with Copilot wants to merge 1 commit into
Open
Fix always-true response.c_str() guards in Device_WiFi_SSID RPC response handling#402Vismalskumar0 with Copilot wants to merge 1 commit into
response.c_str() guards in Device_WiFi_SSID RPC response handling#402Vismalskumar0 with Copilot wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on Device_WiFi_SSID.cpp update
Fix always-true Mar 12, 2026
response.c_str() guards in Device_WiFi_SSID RPC response handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::string::c_str()never returns null, so all threeif (response.c_str())guards inget_Device_WiFi_SSID_Fieldswere always evaluating to true — silently proceeding to parse empty responses and producing misleading error logs.Changes
Device_WiFi_SSID.cpp: Replaceif (response.c_str())withif (!response.empty())for all three RPC response checks:GetConnectedSSIDGetAvailableInterfacesGetWifiState💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.