Calculate correct cipher output length - #166
Merged
Merged
Conversation
arckoor
force-pushed
the
cipher-output-length
branch
from
October 8, 2025 16:12
a2214fb to
c72ddb7
Compare
Contributor
Author
|
I have frankly no idea why the git ci is failing? |
arckoor
force-pushed
the
cipher-output-length
branch
from
March 3, 2026 21:50
c72ddb7 to
9e0f6c8
Compare
Owner
|
@arckoor Sorry for the wait here can you rebase to make sure CI is still good, otherwise lgtm |
arckoor
force-pushed
the
cipher-output-length
branch
from
May 7, 2026 15:26
9e0f6c8 to
de139d3
Compare
Owner
|
@arckoor I'll probably release 0.13 of the crate later today, if you have any other changes you'd want in lmk |
Contributor
Author
|
I don't have any other things that wouldn't first need changes in botan itself, so release away :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155 (I think at least? cc @teythoon)
botan_cipher_output_lengthassumes you ask for the full message length and always includes the tag, hence the somewhat awkward calculation to add / subtract that if we're not at the end yet.The added test would previously fail.